content/browser/renderer_host/render_widget_host_view_android.cc - Issue 499393002: Set the Insertion handle correctly while showing the paste popup menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 499393002: Set the Insertion handle correctly while showing the paste popup menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added wait for the long press event to respond in the unit test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 704604eb496c06524e35c68622be7f5a9e0765ab..eaa2c5a255ab45b9cd8858db1a2d574d9397f426 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1544,7 +1544,7 @@ void RenderWidgetHostViewAndroid::OnShowingPastePopup(

// TODO(jdduke): Remove this workaround when auxiliary paste popup

// notifications are no longer required, crbug.com/398170.

cc::ViewportSelectionBound insertion_bound;

- insertion_bound.type = cc::SELECTION_BOUND_LEFT;

+ insertion_bound.type = cc::SELECTION_BOUND_CENTER;

insertion_bound.visible = true;

insertion_bound.edge_top = point;

insertion_bound.edge_bottom = point;