Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 499383002: Move deduping_factory files. (Closed)

Created:
6 years, 4 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move deduping_factory files. BUG=352290 Committed: https://crrev.com/5c427ae503f1b035a7758e1ef34a4869bfa71f12 Cr-Commit-Position: refs/heads/master@{#291899}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -386 lines) Patch
D chrome/browser/extensions/api/declarative/deduping_factory.h View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/extensions/api/declarative/deduping_factory_unittest.cc View 1 chunk +0 lines, -199 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/browser/api/declarative/deduping_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/declarative/deduping_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
wjmaclean
This is a small patch for a (I think) simple move. Please let me know ...
6 years, 4 months ago (2014-08-25 17:30:01 UTC) #1
sky
LGTM - in the future you don't need me for these files. In theses cases ...
6 years, 4 months ago (2014-08-25 19:42:05 UTC) #2
wjmaclean
On 2014/08/25 19:42:05, sky wrote: > LGTM - in the future you don't need me ...
6 years, 4 months ago (2014-08-25 19:44:28 UTC) #3
not at google - send to devlin
You should get rockot/fsamuel to review this, I don't have any context.
6 years, 4 months ago (2014-08-25 20:28:36 UTC) #4
Fady Samuel
This is an effort to move as much of the WebRequest API as we can ...
6 years, 4 months ago (2014-08-25 20:35:18 UTC) #5
not at google - send to devlin
fun, lgtm.
6 years, 4 months ago (2014-08-25 20:36:06 UTC) #6
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 4 months ago (2014-08-25 20:45:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/499383002/1
6 years, 4 months ago (2014-08-25 20:47:01 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 21:07:22 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 21:09:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45982) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/8743) ios_rel_device ...
6 years, 4 months ago (2014-08-25 21:09:22 UTC) #11
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 3 months ago (2014-08-26 12:38:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/499383002/20001
6 years, 3 months ago (2014-08-26 12:40:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (20001) as d669baebf7364640a0e59743e4d4656cba887f7b
6 years, 3 months ago (2014-08-26 13:48:37 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c427ae503f1b035a7758e1ef34a4869bfa71f12
Cr-Commit-Position: refs/heads/master@{#291899}

Powered by Google App Engine
This is Rietveld 408576698