Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 499363003: Add blink support to --browser=trybot (Closed)

Created:
6 years, 4 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add blink support to --browser=trybot BUG=401180 Committed: https://crrev.com/d21a08112f5df0b117b9657c7d4b5a93baa16356 Cr-Commit-Position: refs/heads/master@{#291789}

Patch Set 1 #

Patch Set 2 : Stubbed out os.chdir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -50 lines) Patch
M tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py View 6 chunks +80 lines, -41 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py View 1 5 chunks +36 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/unittest/system_stub.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sullivan
sullivan@chromium.org changed reviewers: + dtu@chromium.org, tonyg@chromium.org
6 years, 4 months ago (2014-08-25 18:36:17 UTC) #1
sullivan
6 years, 4 months ago (2014-08-25 18:36:18 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-25 20:06:08 UTC) #3
tonyg
lgtm
6 years, 4 months ago (2014-08-25 20:06:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/499363003/1
6 years, 4 months ago (2014-08-25 20:06:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-25 21:26:06 UTC) #6
sullivan
The CQ bit was checked by sullivan@chromium.org
6 years, 4 months ago (2014-08-25 21:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/499363003/20001
6 years, 4 months ago (2014-08-25 21:39:26 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-25 22:38:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as cd19dd707fe2acddcc66212ec2f68bb00ab8a360
6 years, 3 months ago (2014-08-25 23:47:09 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d21a08112f5df0b117b9657c7d4b5a93baa16356
Cr-Commit-Position: refs/heads/master@{#291789}

Powered by Google App Engine
This is Rietveld 408576698