Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 499363002: Schedule floating control. (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Schedule floating control. This CL makes several changes to the scheduling algorithm to handle control flow that is not connected to End. Such control nodes constitute "floating control islands" that must be linearized by the schedule. This is done by considering such nodes to be schedulable, and then editing the control dependencies after a first pass of scheduling. Then a subsequent pass of scheduling will place all nodes correctly into the fully connected graph. R=mstarzinger@chromium.org, rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23411

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -247 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-properties.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M src/compiler/schedule.h View 1 9 chunks +16 lines, -13 lines 0 comments Download
M src/compiler/scheduler.h View 1 3 chunks +29 lines, -8 lines 0 comments Download
M src/compiler/scheduler.cc View 1 18 chunks +301 lines, -134 lines 0 comments Download
M src/compiler/verifier.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 11 chunks +124 lines, -79 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-25 16:34:53 UTC) #1
Michael Starzinger
LGTM, very nice! https://codereview.chromium.org/499363002/diff/1/src/compiler/scheduler.h File src/compiler/scheduler.h (right): https://codereview.chromium.org/499363002/diff/1/src/compiler/scheduler.h#newcode39 src/compiler/scheduler.h:39: struct SchedulerData { nit: Can we ...
6 years, 3 months ago (2014-08-26 14:49:24 UTC) #2
titzer
6 years, 3 months ago (2014-08-26 15:25:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698