Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 499343002: Added vector-based loadic hydrogen stubs. Not yet callable. (Closed)

Created:
6 years, 4 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Added vector-based loadic hydrogen stubs. Not yet callable. The next step is to integrate the use of vector[slot] into the IC infrastructure so it can do the right thing for a vector-based ic. Then these stubs can be installed. For now, they immediately bail out to the miss handler. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23405

Patch Set 1 #

Patch Set 2 : Code comments. #

Patch Set 3 : More comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 1 chunk +13 lines, -0 lines 1 comment Download
M src/code-stubs.h View 1 2 2 chunks +102 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/ic/ic.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, This CL adds the 4 required code stubs to the system for vector ...
6 years, 3 months ago (2014-08-26 12:55:07 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/499343002/diff/40001/src/arm64/code-stubs-arm64.cc File src/arm64/code-stubs-arm64.cc (right): https://codereview.chromium.org/499343002/diff/40001/src/arm64/code-stubs-arm64.cc#newcode4603 src/arm64/code-stubs-arm64.cc:4603: void LoadICTrampolineStub::Generate(MacroAssembler* masm) { Why not ...
6 years, 3 months ago (2014-08-26 13:26:57 UTC) #2
mvstanton
6 years, 3 months ago (2014-08-26 14:12:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 23405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698