Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 499293003: IDL: Avoid generating empty ConstantConfiguration arrays (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Avoid generating empty ConstantConfiguration arrays If all constants in an interface are runtime enabled, an empty (zero-length) C++ array would be generated, which isn't a good idea. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180890

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface2.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jens Widell
PTAL The issue caused compilation errors in another CL that attempted to make this change: ...
6 years, 3 months ago (2014-08-25 16:42:58 UTC) #1
sof
Test coverage would be preferable.
6 years, 3 months ago (2014-08-25 20:05:45 UTC) #2
Jens Widell
On 2014/08/25 20:05:45, sof wrote: > Test coverage would be preferable. Fixed by adding a ...
6 years, 3 months ago (2014-08-26 05:13:38 UTC) #3
haraken
LGTM
6 years, 3 months ago (2014-08-26 05:22:19 UTC) #4
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 3 months ago (2014-08-26 05:24:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/499293003/20001
6 years, 3 months ago (2014-08-26 05:25:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-26 05:30:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 05:31:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46216)
6 years, 3 months ago (2014-08-26 05:31:45 UTC) #9
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 3 months ago (2014-08-26 05:39:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/499293003/40001
6 years, 3 months ago (2014-08-26 05:40:20 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-26 06:42:22 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 08:07:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180890

Powered by Google App Engine
This is Rietveld 408576698