gpu: support immutable texture on Linux Mesa driver and GLES3.

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 218 matching lines @@
       reinterpret_cast<const char*>(glGetString(GL_EXTENSIONS)));
 
   bool npot_ok = false;
 
   const char* renderer_str =
       reinterpret_cast<const char*>(glGetString(GL_RENDERER));
   if (renderer_str) {
     feature_flags_.is_angle = StartsWithASCII(renderer_str, "ANGLE", true);
   }
 
+  bool is_es = false;
   bool is_es3 = false;
   const char* version_str =
       reinterpret_cast<const char*>(glGetString(GL_VERSION));
   if (version_str) {
     std::string lstr(base::StringToLowerASCII(std::string(version_str)));
+    is_es = (lstr.substr(0, 9) == "opengl es");
     is_es3 = (lstr.substr(0, 12) == "opengl es 3.");
   }
 
   AddExtensionString("GL_ANGLE_translated_shader_source");
   AddExtensionString("GL_CHROMIUM_async_pixel_transfers");
   AddExtensionString("GL_CHROMIUM_bind_uniform_location");
   AddExtensionString("GL_CHROMIUM_command_buffer_query");
   AddExtensionString("GL_CHROMIUM_command_buffer_latency_query");
   AddExtensionString("GL_CHROMIUM_copy_texture");
   AddExtensionString("GL_CHROMIUM_get_error_query");
@@ skipping 135 matching lines @@
 
   if (extensions.Contains("GL_OES_element_index_uint") ||
       gfx::HasDesktopGLFeatures()) {
     AddExtensionString("GL_OES_element_index_uint");
     validators_.index_type.AddValue(GL_UNSIGNED_INT);
   }
 
   bool enable_texture_format_bgra8888 = false;
   bool enable_read_format_bgra = false;
   bool enable_render_buffer_bgra = false;
+  // Only APPLE_texture_format_BGRA8888 extension allows BGRA8_EXT in GLES's
+  // glTexStorage2D.
+  bool enable_immutable_texture_format_bgra_on_es =
+      extensions.Contains("GL_APPLE_texture_format_BGRA8888");
 
   // Check if we should allow GL_EXT_texture_format_BGRA8888
   if (extensions.Contains("GL_EXT_texture_format_BGRA8888") ||
-      extensions.Contains("GL_APPLE_texture_format_BGRA8888") ||
+      enable_immutable_texture_format_bgra_on_es ||
       extensions.Contains("GL_EXT_bgra")) {
     enable_texture_format_bgra8888 = true;
   }
 
   if (extensions.Contains("GL_EXT_bgra")) {
     enable_render_buffer_bgra = true;
   }
 
   if (extensions.Contains("GL_EXT_read_format_bgra") ||
       extensions.Contains("GL_EXT_bgra")) {
@@ skipping 272 matching lines @@
     validators_.pixel_store.AddValue(GL_PACK_REVERSE_ROW_ORDER_ANGLE);
     validators_.g_l_state.AddValue(GL_PACK_REVERSE_ROW_ORDER_ANGLE);
   }
 
   if (extensions.Contains("GL_ANGLE_texture_usage")) {
     feature_flags_.angle_texture_usage = true;
     AddExtensionString("GL_ANGLE_texture_usage");
     validators_.texture_parameter.AddValue(GL_TEXTURE_USAGE_ANGLE);
   }
 
-  if (extensions.Contains("GL_EXT_texture_storage")) {
+  // Disable it if BGRA8_EXT isn't allowed.
+  bool support_bgra = (enable_texture_format_bgra8888 && !is_es) ||
+                      (enable_immutable_texture_format_bgra_on_es && is_es);
+  if (support_bgra &&
+      (extensions.Contains("GL_EXT_texture_storage") ||
+       extensions.Contains("GL_ARB_texture_storage") || is_es3)) {
     feature_flags_.ext_texture_storage = true;
     AddExtensionString("GL_EXT_texture_storage");
     validators_.texture_parameter.AddValue(GL_TEXTURE_IMMUTABLE_FORMAT_EXT);
     if (enable_texture_format_bgra8888)
         validators_.texture_internal_format_storage.AddValue(GL_BGRA8_EXT);
     if (enable_texture_float) {
         validators_.texture_internal_format_storage.AddValue(GL_RGBA32F_EXT);
         validators_.texture_internal_format_storage.AddValue(GL_RGB32F_EXT);
         validators_.texture_internal_format_storage.AddValue(GL_ALPHA32F_EXT);
         validators_.texture_internal_format_storage.AddValue(
@@ skipping 148 matching lines @@
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu