Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 499253002: Revert of Merge apps/pref* to extensions/browser/pref* (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Merge apps/pref* to extensions/browser/pref* (patchset #1 of https://codereview.chromium.org/493003002/) Reason for revert: Breaks GN: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/10608 Original issue's description: > Merge apps/pref* to extensions/browser/pref* > > The pref's exclusive user AppWindow will move to extensions/browser > > Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h} > Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc > > BUG=403726 > TBR=bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc. > > Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7 TBR=benwells@chromium.org,bauerb@chromium.org,bartfab@chromium.org,hashimoto@chromium.org NOTREECHECKS=true NOTRY=true BUG=403726 Committed: https://crrev.com/6f93ff91cd3dba63a70f2b860a99c34503580fbb Cr-Commit-Position: refs/heads/master@{#291652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -13 lines) Patch
M apps/app_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/apps.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A apps/pref_names.h View 1 chunk +18 lines, -0 lines 0 comments Download
A apps/pref_names.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A apps/prefs.h View 1 chunk +21 lines, -0 lines 0 comments Download
A apps/prefs.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/apps/app_launch_for_metro_restart_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/pref_names.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Merge apps/pref* to extensions/browser/pref*
6 years, 3 months ago (2014-08-25 08:45:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/499253002/1
6 years, 3 months ago (2014-08-25 08:46:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as acf084eb2df3b50cdf36a39f6fd01e30f9f82e6f
6 years, 3 months ago (2014-08-25 08:47:13 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f93ff91cd3dba63a70f2b860a99c34503580fbb
Cr-Commit-Position: refs/heads/master@{#291652}

Powered by Google App Engine
This is Rietveld 408576698