Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 499163002: Use qualified path for grit/ui_strings.h (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dcheng, nona+watch_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, James Su, stevenjb+watch_chromium.org, ben+ash_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use qualified path for grit/ui_strings.h This was generated by the following command line: $ for f in $(g grep -l '"grit/ui_strings.h"' -- '*.cc' '*.mm' '*.h'); do sed -i -e 's/"grit\/ui_strings.h"/"ui\/strings\/grit\/ui_strings.h"/' $f; done $ python ./tools/git/for-all-touched-files.py -c "./tools/sort-headers.py -f [[FILENAME]]" BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/0aff6f3f6d49226f59a6b5adce44b1cd0b30ffbd Cr-Commit-Position: refs/heads/master@{#291700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
M apps/ui/views/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M apps/ui/views/app_window_frame_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/restart_browser.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ui_localizer.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/infobars/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/infobars/core/confirm_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/app_list_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_folder_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/speech_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/menu_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/formatter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/time_format.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/bytes_formatting.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/settings_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/shell_dialogs/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/cocoa/bridged_content_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_editing_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
6 years, 4 months ago (2014-08-25 01:48:29 UTC) #1
Nico
lgtm, thanks! ui_strings.gyp still needs grit_target.gypi because app_locale_settings.grd includes aren't qualified yet. I'm idly wondering ...
6 years, 4 months ago (2014-08-25 16:04:54 UTC) #2
Nico
On 2014/08/25 16:04:54, Nico (afk vacation til Aug 24) wrote: > lgtm, thanks! > > ...
6 years, 4 months ago (2014-08-25 16:05:39 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-25 16:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/499163002/1
6 years, 4 months ago (2014-08-25 16:06:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-25 16:42:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 16:46:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6385)
6 years, 4 months ago (2014-08-25 16:46:13 UTC) #8
tfarina
TBRing Ben for this...
6 years, 4 months ago (2014-08-25 16:51:35 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-25 16:51:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/499163002/1
6 years, 4 months ago (2014-08-25 16:52:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (1) as d8621d6ab7b760fbaede31d9d8614ce642619179
6 years, 4 months ago (2014-08-25 16:56:38 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aff6f3f6d49226f59a6b5adce44b1cd0b30ffbd
Cr-Commit-Position: refs/heads/master@{#291700}

Powered by Google App Engine
This is Rietveld 408576698