Make test_results deployable again.

Make test_results deployable again.

This uses a slightly better version of what chromium_cq_status does
to work around the import problems with appengine apps and test.py.
test.py wants absolute module paths and appengine want's app-root-relative
paths.

Add the app-root to sys.path where needed and then pop it off.
This is not awesome because python modules don't unload. So, once
you load "model" from chromium_cq_status, it will keep pointing to
the wrong thing for test_results. "Fix" this by calling reload on the
modules that have conflicting names betwen the two apps.

Again, this is not the right long-term solution, but it gets
test_results deployable while still having it work with test.py.

Also, rename jsonresults_unittest to jsonresults_test so test.py
picks it up.

BUG=401856, 405672
Committed: https://chromium.googlesource.com/infra/infra/+/1bce782ccc4165adef0f14a1dda566f6784a7014

[ojan, 2014-08-24 06:07:31]

I know this isn't awesome, but it's the best my python-fu could come up with and
it's an improvement over what chromium_cq_status was doing IMO.

I'd really like to be able to push test_results tomorrow to fix git migration
things and if possible I'd like not to lose the test.py integration in the
process. So, this was my stopgap until one of you smarter folks come up with a
good design.

[eseidel, 2014-08-24 06:10:58]

Did you mean to add a file for PathMangler or is it already there?

[ojan, 2014-08-24 06:22:58]

Whoops. It's there now.

[eseidel, 2014-08-25 20:23:37]

Seems fine to me.  We can always change it later.

rslgtm

https://codereview.chromium.org/499103002/diff/40001/appengine/test_results/m...
File appengine/test_results/model/testfile.py (right):

https://codereview.chromium.org/499103002/diff/40001/appengine/test_results/m...
appengine/test_results/model/testfile.py:35: reload(model)
Is this needed?

[ojan, 2014-08-25 20:24:25]

https://codereview.chromium.org/499103002/diff/40001/appengine/test_results/m...
File appengine/test_results/model/testfile.py (right):

https://codereview.chromium.org/499103002/diff/40001/appengine/test_results/m...
appengine/test_results/model/testfile.py:35: reload(model)
On 2014/08/25 20:23:36, eseidel wrote:
> Is this needed?

Whoops. Leftover from an earlier iteration.

[ojan, 2014-08-25 22:03:11]

Will need an lgtm from an infra OWNER as well. agable, iannucci, stip?

[agable, 2014-08-26 01:24:16]

On 2014/08/25 22:03:11, ojan-only-code-yellow-reviews wrote:
> Will need an lgtm from an infra OWNER as well. agable, iannucci, stip?

You're right, kinda hacky, but looks like it does the right thing. I think we're
going to just have to accept some flavor of path-hacks in order to get appengine
and test.py living happily together -- that or use an appengine-specific version
of test.py that doesn't try to treat all the apps as a single package (I'm in
favor of that one for the long term). But this should work for now, so lgtm.

[ojan, 2014-08-26 01:59:55]

On 2014/08/26 at 01:24:16, agable wrote:
> On 2014/08/25 22:03:11, ojan-only-code-yellow-reviews wrote:
> > Will need an lgtm from an infra OWNER as well. agable, iannucci, stip?
> 
> You're right, kinda hacky, but looks like it does the right thing. I think
we're going to just have to accept some flavor of path-hacks in order to get
appengine and test.py living happily together -- that or use an
appengine-specific version of test.py that doesn't try to treat all the apps as
a single package (I'm in favor of that one for the long term). But this should
work for now, so lgtm.

To be totally clear, I do *not* think we should do what I'm doing here
long-term. I'm just trying to get this app deployable since that's the P0 issue
and I don't really have the python-fu to figure out a better solution.

An appengine specific script seems reasonable to me. It'd be nice if there were
also a meta all-tests.py or something that ran both the appengine and the infra
tests (in subprocesses or something presumably so they don't have the module
conflict).

[ojan, 2014-08-26 02:00:09]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:00:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/499103002/60001

[commit-bot: I haz the power, 2014-08-26 02:01:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[commit-bot: I haz the power, 2014-08-26 02:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:03:02]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[eseidel, 2014-08-26 02:05:04]

Sorry.  infra_tester presubmit is busted atm.  agable is looking at the error as
we speak.

[ojan, 2014-08-26 03:18:48]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-08-26 03:19:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/499103002/60001

[commit-bot: I haz the power, 2014-08-26 03:21:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[commit-bot: I haz the power, 2014-08-26 03:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 03:26:01]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[ojan, 2014-08-26 06:01:04]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-08-26 06:02:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/499103002/60001

[commit-bot: I haz the power, 2014-08-26 06:04:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[commit-bot: I haz the power, 2014-08-26 06:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 06:07:03]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[eseidel, 2014-08-27 17:50:22]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-08-27 17:50:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/499103002/60001

[commit-bot: I haz the power, 2014-08-27 17:51:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[commit-bot: I haz the power, 2014-08-27 17:52:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 17:52:59]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[ojan, 2014-08-28 03:40:05]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:40:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/499103002/80001

[commit-bot: I haz the power, 2014-08-28 03:43:10]

Committed patchset #5 (id:80001) as 1bce782ccc4165adef0f14a1dda566f6784a7014