build/util/lastchange.py - Issue 499063002: Temporarily make lastchange use only the git hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/util/lastchange.py

Issue 499063002: Temporarily make lastchange use only the git hash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also touch chrome_browser_main to try to force compile/tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/util/lastchange.py

diff --git a/build/util/lastchange.py b/build/util/lastchange.py

index 28a266ddaf7ad977d37f4499076b0aa84eca19c5..87094e9592c93b13c79efb6eb751ef76e8645138 100755

--- a/build/util/lastchange.py

+++ b/build/util/lastchange.py

@@ -107,6 +107,10 @@ def FetchGitRevision(directory):

hsh = output

if not hsh:

return None

+ return VersionInfo('git', hsh)

+ # TODO(agable): Re-enable this code after the lastchange value can accept

+ # strings longer than 64 characters. See crbug.com/406783.

+ # The following code is unreachable.

Ryan Tseng 2014/08/23 18:39:32 We can just delete this? Or pylint will explode (o

agable 2014/08/23 18:42:36 Yeah I suppose I can delete the code and just rela

pos = ''

proc = RunGitCommand(directory, ['show', '-s', '--format=%B', 'HEAD'])

if proc:

« no previous file with comments | « no previous file | build/whitespace_file.txt » ('j') | chrome/browser/chrome_browser_main.cc » ('J')