Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 499063002: Temporarily make lastchange use only the git hash. (Closed)

Created:
6 years, 4 months ago by agable
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Temporarily make lastchange use only the git hash. This will fix the currently failing browser_tests CloudPolicyTests, which fail because the lastchange string is too long. TBR=scottmg@chromium.org, tandrii@chromium.org NOTRY=True NOTREECHECKS=True TEST=passed browser_tests on linux_chromium_rel trybot BUG=406783 Committed: https://crrev.com/993d8dde169387c432c706e5b7a559dcb622bcc9 Cr-Commit-Position: refs/heads/master@{#291571}

Patch Set 1 #

Patch Set 2 : Also touch whitespace file to force tests on trybot #

Patch Set 3 : Also touch chrome_browser_main to try to force compile/tests #

Total comments: 4

Patch Set 4 : Revert whitespace changes now that trybot has succeeded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/util/lastchange.py View 1 2 3 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
agable
6 years, 4 months ago (2014-08-23 17:32:02 UTC) #1
agable
On 2014/08/23 17:32:02, agable wrote: I am TBR'ing and directly landing this CL to fix ...
6 years, 4 months ago (2014-08-23 17:34:04 UTC) #2
Ryan Tseng
https://codereview.chromium.org/499063002/diff/40001/build/util/lastchange.py File build/util/lastchange.py (right): https://codereview.chromium.org/499063002/diff/40001/build/util/lastchange.py#newcode113 build/util/lastchange.py:113: # The following code is unreachable. We can just ...
6 years, 4 months ago (2014-08-23 18:39:32 UTC) #3
tandrii(chromium)
LGTM, agree with Ryan's comments!
6 years, 4 months ago (2014-08-23 18:42:19 UTC) #4
agable
https://codereview.chromium.org/499063002/diff/40001/build/util/lastchange.py File build/util/lastchange.py (right): https://codereview.chromium.org/499063002/diff/40001/build/util/lastchange.py#newcode113 build/util/lastchange.py:113: # The following code is unreachable. On 2014/08/23 18:39:32, ...
6 years, 4 months ago (2014-08-23 18:42:37 UTC) #5
agable
The CQ bit was checked by agable@chromium.org
6 years, 4 months ago (2014-08-23 18:48:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/499063002/60001
6 years, 4 months ago (2014-08-23 18:49:10 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (60001) as b2e2e15044497d6d91601fb95528f922549dcc14
6 years, 4 months ago (2014-08-23 18:50:38 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:30:33 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/993d8dde169387c432c706e5b7a559dcb622bcc9
Cr-Commit-Position: refs/heads/master@{#291571}

Powered by Google App Engine
This is Rietveld 408576698