Issue 499003002: Do threading.Lock the Right Way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 499003002: Do threading.Lock the Right Way. (Closed)

Created:
6 years, 4 months ago by szager1

Modified:
6 years, 4 months ago

Reviewers:
dnj, cmp, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Do threading.Lock the Right Way. R=cmp@chromium.org, dnj@chromium.org, iannucci@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291573

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -16 lines)			Patch
	M	git_cache.py	View	1	1 chunk	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm with nit https://codereview.chromium.org/499003002/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/499003002/diff/1/git_cache.py#newcode216 git_cache.py:216: raise RuntimeError('No global cache.cachepath git configuration ...

6 years, 4 months ago (2014-08-23 02:55:07 UTC) #3

szager1

6 years, 4 months ago (2014-08-23 03:33:44 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/499003002/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/499003002/diff/1/git_cache.py#newcode216
git_cache.py:216: raise RuntimeError('No global cache.cachepath git
configuration found.')
On 2014/08/23 02:55:07, cmp wrote:
> nit: < 80 chars

Done.

Expand Messages | Collapse Messages

Issue 499003002: Do threading.Lock the Right Way. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages