Firing event to broker without worker thread.

ceee/ie/plugin/bho/events_funnel.cc

Index: ceee/ie/plugin/bho/events_funnel.cc
===================================================================
--- ceee/ie/plugin/bho/events_funnel.cc	(revision 66617)
+++ ceee/ie/plugin/bho/events_funnel.cc	(working copy)
@@ -7,21 +7,18 @@
 
 #include "ceee/ie/plugin/bho/events_funnel.h"
 
+#include <atlbase.h>
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
+#include "ceee/ie/broker/broker_rpc_client.h"
 #include "ceee/ie/common/ceee_module_util.h"
 
 
-EventsFunnel::EventsFunnel(bool keep_broker_alive)
-    : keep_broker_alive_(keep_broker_alive) {
-  if (keep_broker_alive_)
-    ceee_module_util::AddRefModuleWorkerThread();
+EventsFunnel::EventsFunnel() {
 }
 
 EventsFunnel::~EventsFunnel() {
-  if (keep_broker_alive_)
-    ceee_module_util::ReleaseModuleWorkerThread();
 }
 
 HRESULT EventsFunnel::SendEvent(const char* event_name,
@@ -36,7 +33,21 @@
     base::JSONWriter::Write(&list, false, &event_args_str);
   }
 
-  EventsFunnel thread_locker(!keep_broker_alive_);
-  ceee_module_util::FireEventToBroker(event_name, event_args_str);
-  return S_OK;
+  return SendEventToBroker(event_name, event_args_str.c_str());
 }
+
+HRESULT EventsFunnel::SendEventToBroker(const char* event_name,
+                                        const char* event_args) {
+  if (!broker_rpc_client_.get()) {
+    broker_rpc_client_.reset(new BrokerRpcClient());
+    if (!broker_rpc_client_.get())
+      return E_OUTOFMEMORY;
+    HRESULT hr = BrokerRpcClient::StartServer();
+    if (FAILED(hr))
+      return hr;

[Sigurður Ásgeirsson, 2010/11/19 18:29:30]

Do you want to do broker_rpc_client_.reset() on failure cases here? Maybe keep a
local scoped_ptr and hand over ownership to the member ptr only on success?

[Vitaly Buka corp, 2010/11/19 20:30:38]

No. It is by design. It prevents from new attempts to init broker. It will kill
IE if we are broken
On 2010/11/19 18:29:30, Ruðrugis wrote:

+    hr = broker_rpc_client_->Connect();
+    if (FAILED(hr))
+      return hr;
+  }
+  return broker_rpc_client_->FireEvent(event_name, event_args);
+}