Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: ceee/ie/plugin/bho/mediumtest_browser_helper_object.cc

Issue 4989002: Firing event to broker without worker thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ceee/ie/plugin/bho/infobar_events_funnel.h ('k') | ceee/ie/plugin/bho/tab_events_funnel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ceee/ie/plugin/bho/mediumtest_browser_helper_object.cc
===================================================================
--- ceee/ie/plugin/bho/mediumtest_browser_helper_object.cc (revision 66617)
+++ ceee/ie/plugin/bho/mediumtest_browser_helper_object.cc (working copy)
@@ -82,6 +82,15 @@
browser, parent_browser, this, IID_IFrameEventHandler, handler);
}
+ // Overrides original implementation to suppress calls to broker.
+ WebProgressNotifier* CreateWebProgressNotifier() {
+ scoped_ptr<WebProgressNotifier> web_progress_notifier(
+ new TestingWebProgressNotifier());
+ HRESULT hr = web_progress_notifier->Initialize(this, tab_window_,
+ web_browser_);
+ return SUCCEEDED(hr) ? web_progress_notifier.release() : NULL;
+ }
+
virtual TabEventsFunnel& tab_events_funnel() {
return mock_tab_events_funnel_;
}
@@ -214,6 +223,23 @@
CComPtr<ICeeeBrokerRegistrar> broker_keeper_;
private:
+ class TestingWebProgressNotifier : public WebProgressNotifier {
+ public:
+ class TesingNavigationEventsFunne : public WebNavigationEventsFunnel {
+ public:
+ HRESULT SendEventToBroker(const char*, const char*) {
+ return S_OK;
+ }
+ };
+
+ virtual WebNavigationEventsFunnel* webnavigation_events_funnel() {
+ if (!webnavigation_events_funnel_.get())
+ webnavigation_events_funnel_.reset(new TesingNavigationEventsFunne());
+
+ return webnavigation_events_funnel_.get();
+ }
+ };
+
MockChromeFrameHost* mock_chrome_frame_host_;
StrictMock<testing::MockTabEventsFunnel> mock_tab_events_funnel_;
};
« no previous file with comments | « ceee/ie/plugin/bho/infobar_events_funnel.h ('k') | ceee/ie/plugin/bho/tab_events_funnel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698