Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: ceee/ie/plugin/bho/events_funnel.h

Issue 4989002: Firing event to broker without worker thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ceee/ie/plugin/bho/cookie_events_funnel.h ('k') | ceee/ie/plugin/bho/events_funnel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ceee/ie/plugin/bho/events_funnel.h
===================================================================
--- ceee/ie/plugin/bho/events_funnel.h (revision 66617)
+++ ceee/ie/plugin/bho/events_funnel.h (working copy)
@@ -11,15 +11,16 @@
#include <windows.h>
#include "base/basictypes.h"
+#include "base/scoped_ptr.h"
class Value;
+class BrokerRpcClient;
+
// Defines a base class for sending events to the Broker.
class EventsFunnel {
protected:
- // @param keep_broker_alive If true broker will be alive during
- // lifetime of this funnel, otherwise only during SendEvent.
- explicit EventsFunnel(bool keep_broker_alive);
+ EventsFunnel();
virtual ~EventsFunnel();
// Send the given event to the Broker.
@@ -28,10 +29,14 @@
// protected virtual for testability...
virtual HRESULT SendEvent(const char* event_name, const Value& event_args);
+ protected:
+ virtual HRESULT SendEventToBroker(const char* event_name,
+ const char* event_args);
+
private:
- // If true constructor/destructor of class increments/decrements ref counter
- // of broker thread. Otherwise SendEvent does it for every event.
- const bool keep_broker_alive_;
+ // Pointer to broker client. If is not NULL attempt to connect was performed
+ // and new attempts are not nessesary.
+ scoped_ptr<BrokerRpcClient> broker_rpc_client_;
DISALLOW_COPY_AND_ASSIGN(EventsFunnel);
};
« no previous file with comments | « ceee/ie/plugin/bho/cookie_events_funnel.h ('k') | ceee/ie/plugin/bho/events_funnel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698