Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: content/browser/frame_host/navigator_impl.cc

Issue 498883002: Add/improve tracing in navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes based on Charlie's review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/navigator_impl.h" 5 #include "content/browser/frame_host/navigator_impl.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "content/browser/frame_host/frame_tree.h" 9 #include "content/browser/frame_host/frame_tree.h"
10 #include "content/browser/frame_host/frame_tree_node.h" 10 #include "content/browser/frame_host/frame_tree_node.h"
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 if (delegate_) { 319 if (delegate_) {
320 delegate_->DidRedirectProvisionalLoad( 320 delegate_->DidRedirectProvisionalLoad(
321 render_frame_host, validated_target_url); 321 render_frame_host, validated_target_url);
322 } 322 }
323 } 323 }
324 324
325 bool NavigatorImpl::NavigateToEntry( 325 bool NavigatorImpl::NavigateToEntry(
326 RenderFrameHostImpl* render_frame_host, 326 RenderFrameHostImpl* render_frame_host,
327 const NavigationEntryImpl& entry, 327 const NavigationEntryImpl& entry,
328 NavigationController::ReloadType reload_type) { 328 NavigationController::ReloadType reload_type) {
329 TRACE_EVENT0("browser", "NavigatorImpl::NavigateToEntry"); 329 TRACE_EVENT0("browser,navigation", "NavigatorImpl::NavigateToEntry");
330 330
331 // The renderer will reject IPC messages with URLs longer than 331 // The renderer will reject IPC messages with URLs longer than
332 // this limit, so don't attempt to navigate with a longer URL. 332 // this limit, so don't attempt to navigate with a longer URL.
333 if (entry.GetURL().spec().size() > GetMaxURLChars()) { 333 if (entry.GetURL().spec().size() > GetMaxURLChars()) {
334 LOG(WARNING) << "Refusing to load URL as it exceeds " << GetMaxURLChars() 334 LOG(WARNING) << "Refusing to load URL as it exceeds " << GetMaxURLChars()
335 << " characters."; 335 << " characters.";
336 return false; 336 return false;
337 } 337 }
338 338
339 // This will be used to set the Navigation Timing API navigationStart 339 // This will be used to set the Navigation Timing API navigationStart
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 controller_->GetBrowserContext(), url); 681 controller_->GetBrowserContext(), url);
682 if ((enabled_bindings & BINDINGS_POLICY_WEB_UI) && 682 if ((enabled_bindings & BINDINGS_POLICY_WEB_UI) &&
683 !is_allowed_in_web_ui_renderer) { 683 !is_allowed_in_web_ui_renderer) {
684 // Log the URL to help us diagnose any future failures of this CHECK. 684 // Log the URL to help us diagnose any future failures of this CHECK.
685 GetContentClient()->SetActiveURL(url); 685 GetContentClient()->SetActiveURL(url);
686 CHECK(0); 686 CHECK(0);
687 } 687 }
688 } 688 }
689 689
690 } // namespace content 690 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698