Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 498833002: Move |kSwitchNames| to anonymous namespace. (Closed)

Created:
6 years, 4 months ago by Jorge Lucangeli Obes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move |kSwitchNames| to anonymous namespace. This makes GpuProcessHost::LaunchGpuProcess significantly easier to read. This is in preparation for getting rid of the GPU broker process. Also make "GPU process" capitalization consistent. BUG=329375 TEST=content_shell boots, --disable-gpu-sandbox gets propagated. Committed: https://crrev.com/1f4903ba455aed8cb3863dd41028759158d50c57 Cr-Commit-Position: refs/heads/master@{#291586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -47 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 4 chunks +50 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jorge Lucangeli Obes
Hey guys, I think this is a lot more readable. What do you think?
6 years, 4 months ago (2014-08-22 20:45:15 UTC) #1
piman
lgtm
6 years, 4 months ago (2014-08-22 20:54:05 UTC) #2
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 4 months ago (2014-08-22 21:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/498833002/1
6 years, 4 months ago (2014-08-22 21:07:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-22 22:11:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 22:55:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/4836)
6 years, 4 months ago (2014-08-22 22:55:32 UTC) #7
Jorge Lucangeli Obes
On 2014/08/22 22:55:32, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-22 22:56:38 UTC) #8
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 4 months ago (2014-08-22 22:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/498833002/1
6 years, 4 months ago (2014-08-22 22:57:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as 81737639c1c069c834b1113976d4c33541521535
6 years, 4 months ago (2014-08-23 21:36:15 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f4903ba455aed8cb3863dd41028759158d50c57
Cr-Commit-Position: refs/heads/master@{#291586}

Powered by Google App Engine
This is Rietveld 408576698