Adds tests of home card state transition upon gestures.

athena/home/home_card_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/home/public/home_card.h"
 
 #include <cmath>
 #include <limits>
 
 #include "athena/common/container_priorities.h"
@@ skipping 167 matching lines @@
         }
         break;
       }
       default:
         // do nothing.
         break;
     }
   }
 
  private:
   HomeCard::State GetClosestState() {

[oshima, 2014/08/24 02:22:45]

can this be const?

and document this method.

[Jun Mukai, 2014/08/24 02:27:31]

actually I have another CL https://codereview.chromium.org/502583002/ which does
the documentation. Is that okay to be there?

     // The top position of the bounds for one smaller state than the current
     // one.
     int smaller_top = -1;
     for (int i = HomeCard::VISIBLE_MINIMIZED;
          i >= HomeCard::VISIBLE_CENTERED; --i) {
       HomeCard::State state = static_cast<HomeCard::State>(i);
       int top = GetBoundsForState(screen_bounds_, state).y();
       if (last_estimated_top_ == top) {
         return state;
       } else if (last_estimated_top_ > top) {
         if (smaller_top < 0)
           return state;
 
         if (smaller_top - last_estimated_top_ > (smaller_top - top) / 5) {
           return state;
         } else {
           return static_cast<HomeCard::State>(i + 1);
         }
       }
       smaller_top = top;
     }
 
-    NOTREACHED();
     return last_state_;
   }
 
   void UpdateScrollState(const ui::GestureEvent& event) {
     last_estimated_top_ = event.root_location().y() - y_offset_;
 
     // The bounds which is at one smaller state than the current one.
     gfx::Rect smaller_bounds;
 
     for (int i = HomeCard::VISIBLE_MINIMIZED;
@@ skipping 21 matching lines @@
               last_state_ = static_cast<HomeCard::State>(last_state_ + 1);
             }
           }
           delegate_->OnGestureProgressed(last_state_, state, progress);
         }
         last_state_ = state;
         return;
       }
       smaller_bounds = bounds;
     }
-    NOTREACHED();
   }
 
   Delegate* delegate_;
   HomeCard::State last_state_;
 
   // The offset from the top edge of the home card and the initial position of
   // gesture.
   int y_offset_;
 
   // The estimated top edge of the home card after the last touch event.
@@ skipping 395 matching lines @@
   instance = NULL;
 }
 
 // static
 HomeCard* HomeCard::Get() {
   DCHECK(instance);
   return instance;
 }
 
 }  // namespace athena