Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 498823002: Adds tests of home card state transition upon gestures. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Adds tests of home card state transition upon gestures. BUG=403813 R=oshima@chromium.org TEST=athena_unittests Committed: https://crrev.com/59f71514210683fbb694b5f73e99513203b9e072 Cr-Commit-Position: refs/heads/master@{#291622}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -5 lines) Patch
M athena/home/home_card_impl.cc View 2 chunks +0 lines, -2 lines 2 comments Download
M athena/home/home_card_unittest.cc View 2 chunks +82 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-22 20:08:22 UTC) #1
oshima
lgtm with nits https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc File athena/home/home_card_impl.cc (right): https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc#newcode188 athena/home/home_card_impl.cc:188: HomeCard::State GetClosestState() { can this be ...
6 years, 4 months ago (2014-08-24 02:22:45 UTC) #2
Jun Mukai
https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc File athena/home/home_card_impl.cc (right): https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc#newcode188 athena/home/home_card_impl.cc:188: HomeCard::State GetClosestState() { On 2014/08/24 02:22:45, oshima wrote: > ...
6 years, 4 months ago (2014-08-24 02:27:31 UTC) #3
oshima
On 2014/08/24 02:27:31, Jun Mukai wrote: > https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc > File athena/home/home_card_impl.cc (right): > > https://codereview.chromium.org/498823002/diff/1/athena/home/home_card_impl.cc#newcode188 ...
6 years, 4 months ago (2014-08-24 02:50:07 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 4 months ago (2014-08-24 05:23:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/498823002/1
6 years, 4 months ago (2014-08-24 05:23:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 5ec36af9da6cff4a38b1607e61775f3f341014c4
6 years, 4 months ago (2014-08-24 06:16:54 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59f71514210683fbb694b5f73e99513203b9e072
Cr-Commit-Position: refs/heads/master@{#291622}

Powered by Google App Engine
This is Rietveld 408576698