Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 498813002: Rename the docserver third_party dependency "handlebar" to "motemplate", as part (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou, brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename the docserver third_party dependency "handlebar" to "motemplate", as part of updating that templating library. History: this dependency is owned by me, and I changed the name to avoid confusion with the "handlebars" templating system. R=yoz@chromium.org, brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291550

Patch Set 1 #

Patch Set 2 : imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1422 lines) Patch
M chrome/common/extensions/docs/README View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/build_server.py View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/compiled_file_system.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/jsc_view.py View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/jsc_view_test.py View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/permissions_data_source_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet.py View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_renderer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_renderer_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/handlebar/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/handlebar/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/handlebar/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/handlebar/README.chromium View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/handlebar/handlebar.py View 1 chunk +0 lines, -1158 lines 0 comments Download
A + third_party/motemplate/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/motemplate/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/motemplate/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/motemplate/README.chromium View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/motemplate/motemplate.py View 6 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
yoz: Could you check this? brettw: This is not a new library, it's just a ...
6 years, 4 months ago (2014-08-22 19:50:44 UTC) #1
Yoyo Zhou
LGTM, I didn't check that you didn't leave the string "handlebar" anywhere in the codebase.
6 years, 4 months ago (2014-08-22 20:03:05 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-08-22 22:00:22 UTC) #3
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-22 22:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/498813002/20001
6 years, 4 months ago (2014-08-22 22:04:06 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 23:26:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291550

Powered by Google App Engine
This is Rietveld 408576698