Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: Source/platform/scroll/ScrollView.h

Issue 498773007: Move some scroll invalidations to the paint invalidation phase (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch updated after Dan's review. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Holger Hans Peter Freyther 3 * Copyright (C) 2009 Holger Hans Peter Freyther
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 virtual void paintOverhangAreas(GraphicsContext*, const IntRect& horizontalO verhangArea, const IntRect& verticalOverhangArea, const IntRect& dirtyRect); 264 virtual void paintOverhangAreas(GraphicsContext*, const IntRect& horizontalO verhangArea, const IntRect& verticalOverhangArea, const IntRect& dirtyRect);
265 265
266 virtual void scrollbarExistenceDidChange() = 0; 266 virtual void scrollbarExistenceDidChange() = 0;
267 // These functions are used to create/destroy scrollbars. 267 // These functions are used to create/destroy scrollbars.
268 void setHasHorizontalScrollbar(bool); 268 void setHasHorizontalScrollbar(bool);
269 void setHasVerticalScrollbar(bool); 269 void setHasVerticalScrollbar(bool);
270 270
271 virtual void updateScrollCorner(); 271 virtual void updateScrollCorner();
272 virtual void invalidateScrollCornerRect(const IntRect&) OVERRIDE; 272 virtual void invalidateScrollCornerRect(const IntRect&) OVERRIDE;
273 273
274 virtual void scrollContentsIfNeeded(); 274 void scrollContentsIfNeeded();
275 // Scroll the content by via the compositor. 275 // Scroll the content by via the compositor.
276 virtual bool scrollContentsFastPath(const IntSize& scrollDelta) { return tru e; } 276 virtual bool scrollContentsFastPath(const IntSize& scrollDelta) { return tru e; }
277 // Scroll the content by invalidating everything. 277 // Scroll the content by invalidating everything.
278 virtual void scrollContentsSlowPath(const IntRect& updateRect); 278 virtual void scrollContentsSlowPath(const IntRect& updateRect);
279 279
280 void setScrollOrigin(const IntPoint&, bool updatePositionAtAll, bool updateP ositionSynchronously); 280 void setScrollOrigin(const IntPoint&, bool updatePositionAtAll, bool updateP ositionSynchronously);
281 281
282 // Subclassed by FrameView to check the writing-mode of the document. 282 // Subclassed by FrameView to check the writing-mode of the document.
283 virtual bool isVerticalDocument() const { return true; } 283 virtual bool isVerticalDocument() const { return true; }
284 virtual bool isFlippedDocument() const { return false; } 284 virtual bool isFlippedDocument() const { return false; }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 341
342 void calculateOverhangAreasForPainting(IntRect& horizontalOverhangRect, IntR ect& verticalOverhangRect); 342 void calculateOverhangAreasForPainting(IntRect& horizontalOverhangRect, IntR ect& verticalOverhangRect);
343 void updateOverhangAreas(); 343 void updateOverhangAreas();
344 }; // class ScrollView 344 }; // class ScrollView
345 345
346 DEFINE_TYPE_CASTS(ScrollView, Widget, widget, widget->isScrollView(), widget.isS crollView()); 346 DEFINE_TYPE_CASTS(ScrollView, Widget, widget, widget->isScrollView(), widget.isS crollView());
347 347
348 } // namespace blink 348 } // namespace blink
349 349
350 #endif // ScrollView_h 350 #endif // ScrollView_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698