Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 498773007: Move some scroll invalidations to the paint invalidation phase (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after the review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 virtual void scrollTo(const IntSize&) OVERRIDE; 316 virtual void scrollTo(const IntSize&) OVERRIDE;
317 virtual IntRect scrollableAreaBoundingBox() const OVERRIDE; 317 virtual IntRect scrollableAreaBoundingBox() const OVERRIDE;
318 virtual bool scrollAnimatorEnabled() const OVERRIDE; 318 virtual bool scrollAnimatorEnabled() const OVERRIDE;
319 virtual bool usesCompositedScrolling() const OVERRIDE; 319 virtual bool usesCompositedScrolling() const OVERRIDE;
320 virtual GraphicsLayer* layerForScrolling() const OVERRIDE; 320 virtual GraphicsLayer* layerForScrolling() const OVERRIDE;
321 virtual GraphicsLayer* layerForHorizontalScrollbar() const OVERRIDE; 321 virtual GraphicsLayer* layerForHorizontalScrollbar() const OVERRIDE;
322 virtual GraphicsLayer* layerForVerticalScrollbar() const OVERRIDE; 322 virtual GraphicsLayer* layerForVerticalScrollbar() const OVERRIDE;
323 virtual GraphicsLayer* layerForScrollCorner() const OVERRIDE; 323 virtual GraphicsLayer* layerForScrollCorner() const OVERRIDE;
324 324
325 protected: 325 protected:
326 virtual void scrollContentsIfNeeded();
327 virtual bool scrollContentsFastPath(const IntSize& scrollDelta) OVERRIDE; 326 virtual bool scrollContentsFastPath(const IntSize& scrollDelta) OVERRIDE;
328 virtual void scrollContentsSlowPath(const IntRect& updateRect) OVERRIDE; 327 virtual void scrollContentsSlowPath(const IntRect& updateRect) OVERRIDE;
329 328
330 virtual bool isVerticalDocument() const OVERRIDE; 329 virtual bool isVerticalDocument() const OVERRIDE;
331 virtual bool isFlippedDocument() const OVERRIDE; 330 virtual bool isFlippedDocument() const OVERRIDE;
332 331
333 private: 332 private:
334 explicit FrameView(LocalFrame*); 333 explicit FrameView(LocalFrame*);
335 334
336 void reset(); 335 void reset();
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 379
381 void scheduleUpdateWidgetsIfNecessary(); 380 void scheduleUpdateWidgetsIfNecessary();
382 void updateWidgetsTimerFired(Timer<FrameView>*); 381 void updateWidgetsTimerFired(Timer<FrameView>*);
383 bool updateWidgets(); 382 bool updateWidgets();
384 383
385 void scrollToAnchor(); 384 void scrollToAnchor();
386 void scrollPositionChanged(); 385 void scrollPositionChanged();
387 void didScrollTimerFired(Timer<FrameView>*); 386 void didScrollTimerFired(Timer<FrameView>*);
388 387
389 void updateLayersAndCompositingAfterScrollIfNeeded(); 388 void updateLayersAndCompositingAfterScrollIfNeeded();
390 void updateFixedElementPaintInvalidationRectsAfterScroll(); 389 void updateFixedElementPaintInvalidationRectsAfterScroll();
dsinclair 2014/09/03 14:23:15 Remove?
Julien - ping for review 2014/09/03 22:37:45 Yes!!
391 void updateCompositedSelectionBoundsIfNeeded(); 390 void updateCompositedSelectionBoundsIfNeeded();
392 391
393 bool hasCustomScrollbars() const; 392 bool hasCustomScrollbars() const;
394 bool shouldUseCustomScrollbars(Element*& customScrollbarElement, LocalFrame* & customScrollbarFrame); 393 bool shouldUseCustomScrollbars(Element*& customScrollbarElement, LocalFrame* & customScrollbarFrame);
395 394
396 virtual void updateScrollCorner() OVERRIDE; 395 virtual void updateScrollCorner() OVERRIDE;
397 396
398 FrameView* parentFrameView() const; 397 FrameView* parentFrameView() const;
399 398
400 AXObjectCache* axObjectCache() const; 399 AXObjectCache* axObjectCache() const;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 m_view->setCanInvalidatePaintDuringPerformLayout(m_originalValue); 540 m_view->setCanInvalidatePaintDuringPerformLayout(m_originalValue);
542 } 541 }
543 private: 542 private:
544 FrameView* m_view; 543 FrameView* m_view;
545 bool m_originalValue; 544 bool m_originalValue;
546 }; 545 };
547 546
548 } // namespace blink 547 } // namespace blink
549 548
550 #endif // FrameView_h 549 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698