Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4176)

Unified Diff: chrome/browser/BUILD.gn

Issue 498773005: Add some remoting targets to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 72ed8ac82b9e301028340ea195ce6bad59730b51..c42ed01ead615b009ebe877aabdee1ff096a1002 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -42,8 +42,10 @@ static_library("browser") {
"//chrome/common",
"//chrome/common/net",
"//components/autofill/core/browser",
+ "//components/bookmarks/browser",
"//components/captive_portal",
"//components/cloud_devices/common",
+ "//components/component_updater",
"//components/content_settings/core/common",
"//components/crx_file",
"//components/data_reduction_proxy/browser",
@@ -52,20 +54,33 @@ static_library("browser") {
"//components/favicon/core",
"//components/feedback",
"//components/gcm_driver",
+ "//components/google/core/browser",
"//components/history/core/browser",
"//components/history/core/common",
+ "//components/infobars/core",
+ "//components/invalidation",
"//components/metrics:net",
+ "//components/metrics/proto:proto",
"//components/navigation_metrics",
+ "//components/network_time",
+ "//components/omaha_query_params",
"//components/omnibox",
"//components/os_crypt",
+ "//components/password_manager/core/browser",
+ "//components/password_manager/core/common",
"//components/policy:policy_component",
+ "//components/precache/core",
"//components/query_parser",
"//components/rappor",
+ "//components/renderer_context_menu",
"//components/search",
+ "//components/search_engines",
+ "//components/search_provider_logos",
"//components/signin/core/browser",
"//components/startup_metric_utils",
"//components/strings",
"//components/suggestions",
+ "//components/sync_driver",
"//components/translate/core/browser",
"//components/translate/core/common",
"//components/url_fixer",
@@ -95,18 +110,6 @@ static_library("browser") {
"//ui/strings",
"//ui/resources",
# TODO(GYP)
- #"../components/components.gyp:bookmarks_browser",
- #"../components/components.gyp:google_core_browser",
- #"../components/components.gyp:infobars_core",
- #"../components/components.gyp:invalidation",
- #"../components/components.gyp:network_time",
- #"../components/components.gyp:omaha_query_params",
- #"../components/components.gyp:password_manager_core_browser",
- #"../components/components.gyp:password_manager_core_common",
- #"../components/components.gyp:precache_core",
- #"../components/components.gyp:search_engines",
- #"../components/components.gyp:search_provider_logos",
- #"../components/components.gyp:sync_driver",
#"../jingle/jingle.gyp:notifier",
#"../third_party/libjingle/libjingle.gyp:libjingle",
]
@@ -137,6 +140,7 @@ static_library("browser") {
configs += [ "//content:webrtc_stub_config" ]
deps += [
+ "//apps",
"//cc",
"//chrome/browser/devtools",
"//chrome/browser/performance_monitor",
@@ -180,7 +184,6 @@ static_library("browser") {
"//webkit/browser:storage",
"//webkit/common",
"//webkit/common:storage",
- #"apps", TODO(GYP)
## TODO(tonyg): Remove this dependency (crbug.com/280157).
#"../testing/perf/perf_test.gyp:*", TODO(GYP)
# Note: for this one also remove the webrtc_stub_config
« no previous file with comments | « build/config/features.gni ('k') | components/BUILD.gn » ('j') | remoting/resources/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698