Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 498773005: Add some remoting targets to GN build. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/1c693998d75f78e94862c324afba3815356ecaf1 Cr-Commit-Position: refs/heads/master@{#291731}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git cl try #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+946 lines, -24 lines) Patch
M BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 5 chunks +16 lines, -14 lines 0 comments Download
M components/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +6 lines, -4 lines 0 comments Download
A components/renderer_context_menu/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/variations.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 2 chunks +19 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/google_apis.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 7 chunks +7 lines, -0 lines 0 comments Download
A remoting/base/BUILD.gn View 1 chunk +97 lines, -0 lines 0 comments Download
A remoting/client/BUILD.gn View 1 chunk +50 lines, -0 lines 0 comments Download
A remoting/client/plugin/BUILD.gn View 1 chunk +58 lines, -0 lines 0 comments Download
A + remoting/proto/BUILD.gn View 1 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download
M remoting/proto/chromotocol.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/protocol/BUILD.gn View 1 chunk +160 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 7 chunks +7 lines, -0 lines 0 comments Download
M remoting/remoting_client.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 4 chunks +8 lines, -0 lines 0 comments Download
A remoting/remoting_version.gni View 1 chunk +56 lines, -0 lines 0 comments Download
A remoting/resources/BUILD.gn View 1 2 3 4 5 1 chunk +184 lines, -0 lines 0 comments Download
A remoting/webapp/BUILD.gn View 1 2 3 4 5 1 chunk +196 lines, -0 lines 0 comments Download
M remoting/webapp/build-html.py View 4 chunks +11 lines, -4 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 4 months ago (2014-08-22 20:29:34 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/498773005/diff/80001/remoting/resources/BUILD.gn File remoting/resources/BUILD.gn (right): https://codereview.chromium.org/498773005/diff/80001/remoting/resources/BUILD.gn#newcode141 remoting/resources/BUILD.gn:141: "remoting/resources/ar.pak", Is it possible to generate this list ...
6 years, 4 months ago (2014-08-23 02:00:46 UTC) #2
brettw
Thanks https://codereview.chromium.org/498773005/diff/80001/remoting/resources/BUILD.gn File remoting/resources/BUILD.gn (right): https://codereview.chromium.org/498773005/diff/80001/remoting/resources/BUILD.gn#newcode141 remoting/resources/BUILD.gn:141: "remoting/resources/ar.pak", On 2014/08/23 02:00:46, Sergey Ulanov wrote: > ...
6 years, 4 months ago (2014-08-25 16:58:14 UTC) #3
brettw
Committed patchset #6 to pending queue manually as e147a3d.
6 years, 4 months ago (2014-08-25 19:10:20 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:31 UTC) #5
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/1c693998d75f78e94862c324afba3815356ecaf1
Cr-Commit-Position: refs/heads/master@{#291731}

Powered by Google App Engine
This is Rietveld 408576698