Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 498773003: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index 752dc6637e0fd729c821d827bb97efd71134d594..112cdec887c3cb37b150914a3552ac60c4aa4dc1 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -30,13 +30,13 @@
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
+#include "chrome/grit/chromium_strings.h"
+#include "chrome/grit/generated_resources.h"
#include "components/signin/core/browser/mutable_profile_oauth2_token_service.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
#include "components/signin/core/browser/signin_error_controller.h"
#include "components/signin/core/browser/signin_manager.h"
#include "components/signin/core/common/profile_management_switches.h"
-#include "grit/chromium_strings.h"
-#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/l10n/l10n_util.h"
@@ -197,6 +197,7 @@ class RightAlignedIconLabelButton : public views::LabelButton {
label()->SetHorizontalAlignment(gfx::ALIGN_CENTER);
}
+ private:
DISALLOW_COPY_AND_ASSIGN(RightAlignedIconLabelButton);
};
@@ -452,7 +453,7 @@ class TitleCard : public views::View {
}
private:
- virtual void Layout() OVERRIDE{
+ virtual void Layout() OVERRIDE {
int back_button_width = back_button_->GetPreferredSize().width();
back_button_->SetBounds(0, 0, back_button_width, height());
int label_padding = back_button_width + views::kButtonHEdgeMarginNew;
@@ -461,7 +462,7 @@ class TitleCard : public views::View {
title_label_->SetBounds(label_padding, 0, label_width, height());
}
- virtual gfx::Size GetPreferredSize() const OVERRIDE{
+ virtual gfx::Size GetPreferredSize() const OVERRIDE {
int height = std::max(title_label_->GetPreferredSize().height(),
back_button_->GetPreferredSize().height());
return gfx::Size(width(), height);
@@ -829,7 +830,7 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {
tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;
ProfileMetrics::LogProfileNewAvatarMenuSignin(
ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_SETTINGS);
- } else if (sender == tutorial_not_you_link_){
+ } else if (sender == tutorial_not_you_link_) {
ProfileMetrics::LogProfileNewAvatarMenuUpgrade(
ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU);
ShowView(profiles::BUBBLE_VIEW_MODE_SWITCH_USER, avatar_menu_.get());
@@ -1504,7 +1505,7 @@ views::View* ProfileChooserView::CreateAccountRemovalView() {
}
views::View* ProfileChooserView::CreateWelcomeUpgradeTutorialViewIfNeeded(
- bool tutorial_shown, const AvatarMenu::Item& avatar_item){
+ bool tutorial_shown, const AvatarMenu::Item& avatar_item) {
Profile* profile = browser_->profile();
const int show_count = profile->GetPrefs()->GetInteger(

Powered by Google App Engine
This is Rietveld 408576698