chrome/browser/ui/views/create_application_shortcut_view.cc - Issue 498773003: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 498773003: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | chrome/browser/ui/views/critical_notification_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/create_application_shortcut_view.cc

diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc

index 87675d49e7089ac330e856215c81fa475489ac5d..c5276542888781101b4041025b40edd9807079a3 100644

--- a/chrome/browser/ui/views/create_application_shortcut_view.cc

+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc

@@ -22,12 +22,12 @@

#include "chrome/browser/web_applications/web_app.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/pref_names.h"

+#include "chrome/grit/generated_resources.h"

#include "components/favicon_base/select_favicon_frames.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

#include "extensions/common/extension.h"

-#include "grit/generated_resources.h"

#include "grit/locale_settings.h"

#include "grit/theme_resources.h"

#include "net/base/load_flags.h"

@@ -431,7 +431,6 @@ CreateUrlApplicationShortcutView::CreateUrlApplicationShortcutView(

web_contents_(web_contents),

pending_download_id_(-1),

weak_ptr_factory_(this) {

web_app::GetShortcutInfoForTab(web_contents_, &shortcut_info_);

const WebApplicationInfo& app_info =

extensions::TabHelper::FromWebContents(web_contents_)->web_app_info();