chrome/browser/ui/webui/options/help_overlay_handler.cc - Issue 498773003: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/options/help_overlay_handler.cc

Issue 498773003: Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/options/handler_options_handler.cc ('k') | chrome/browser/ui/webui/options/home_page_overlay_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/options/help_overlay_handler.h"	5 #include "chrome/browser/ui/webui/options/help_overlay_handler.h"

6	6

7 #include "base/values.h"	7 #include "base/values.h"

8 #include "chrome/browser/ui/webui/help/help_handler.h"	8 #include "chrome/browser/ui/webui/help/help_handler.h"

9 #include "chrome/common/chrome_switches.h"	9 #include "chrome/common/chrome_switches.h"

	10 #include "chrome/grit/generated_resources.h"

10 #include "content/public/browser/web_ui.h"	11 #include "content/public/browser/web_ui.h"

11 #include "grit/generated_resources.h"

12	12

13 namespace options {	13 namespace options {

14	14

15 HelpOverlayHandler::HelpOverlayHandler() {	15 HelpOverlayHandler::HelpOverlayHandler() {

16 }	16 }

17	17

18 HelpOverlayHandler::~HelpOverlayHandler() {	18 HelpOverlayHandler::~HelpOverlayHandler() {

19 }	19 }

20	20

21 void HelpOverlayHandler::GetLocalizedValues(	21 void HelpOverlayHandler::GetLocalizedValues(

22 base::DictionaryValue* localized_strings) {	22 base::DictionaryValue* localized_strings) {

23 RegisterTitle(localized_strings, "aboutOverlay", IDS_ABOUT_TITLE);	23 RegisterTitle(localized_strings, "aboutOverlay", IDS_ABOUT_TITLE);

24 HelpHandler::GetLocalizedValues(localized_strings);	24 HelpHandler::GetLocalizedValues(localized_strings);

25 }	25 }

26	26

27 void HelpOverlayHandler::RegisterMessages() {	27 void HelpOverlayHandler::RegisterMessages() {

28 if (::switches::AboutInSettingsEnabled())	28 if (::switches::AboutInSettingsEnabled())

29 web_ui()->AddMessageHandler(new HelpHandler());	29 web_ui()->AddMessageHandler(new HelpHandler());

30 }	30 }

31	31

32 } // namespace options	32 } // namespace options

OLD	NEW