Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 498733002: disable neon proc that is triggering asserts (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

disable neon proc that is triggering asserts BUG=skia:2845 Committed: https://skia.googlesource.com/skia/+/5b2c2c6fd09752641b14766678d62fe50b4e3ef3

Patch Set 1 #

Patch Set 2 : just disable on arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
6 years, 4 months ago (2014-08-22 15:18:04 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-22 15:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/498733002/1
6 years, 4 months ago (2014-08-22 15:18:44 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-22 15:18:45 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-22 15:19:41 UTC) #5
mtklein
lgtm
6 years, 4 months ago (2014-08-22 15:19:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/498733002/20001
6 years, 4 months ago (2014-08-22 15:20:44 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 15:27:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 5b2c2c6fd09752641b14766678d62fe50b4e3ef3

Powered by Google App Engine
This is Rietveld 408576698