Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 498693002: Add some text blob bounds unit tests. (Closed)

Created:
6 years, 4 months ago by f(malita)
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Empty bounds comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -34 lines) Patch
M tests/TextBlobTest.cpp View 1 6 chunks +88 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
Includes some comments I missed in https://codereview.chromium.org/493443004/.
6 years, 4 months ago (2014-08-22 13:58:30 UTC) #1
robertphillips
lgtm modulo some questions https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp File tests/TextBlobTest.cpp (right): https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp#newcode141 tests/TextBlobTest.cpp:141: SkAutoTUnref<const SkTextBlob> blob(builder.build()); Why 65,65 ...
6 years, 4 months ago (2014-08-22 14:23:49 UTC) #2
f(malita)
https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp File tests/TextBlobTest.cpp (right): https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp#newcode141 tests/TextBlobTest.cpp:141: SkAutoTUnref<const SkTextBlob> blob(builder.build()); On 2014/08/22 14:23:48, robertphillips wrote: > ...
6 years, 4 months ago (2014-08-22 14:30:51 UTC) #3
robertphillips
https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp File tests/TextBlobTest.cpp (right): https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp#newcode144 tests/TextBlobTest.cpp:144: Can you add that as a comment?
6 years, 4 months ago (2014-08-22 14:32:50 UTC) #4
f(malita)
https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp File tests/TextBlobTest.cpp (right): https://codereview.chromium.org/498693002/diff/1/tests/TextBlobTest.cpp#newcode144 tests/TextBlobTest.cpp:144: On 2014/08/22 14:32:50, robertphillips wrote: > Can you add ...
6 years, 4 months ago (2014-08-22 14:44:18 UTC) #5
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-08-22 14:44:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/498693002/20001
6 years, 4 months ago (2014-08-22 14:44:34 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 14:50:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 51bf9573b8b875aec47cbeb9f4649f58bcbf56b7

Powered by Google App Engine
This is Rietveld 408576698