Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 498673005: Cleanup: Rename content_resources.gyp to content_resources.gypi and include in content.gyp. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
benwells, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, jochen (gone - plz use gerrit), tfarina
Project:
chromium
Visibility:
Public.

Description

Cleanup: Rename content_resources.gyp to content_resources.gypi and include in content.gyp. TBR=benwells@chromium.org Committed: https://crrev.com/bce0267e0d1abfb8a279c00be1497d941020a6a5 Cr-Commit-Position: refs/heads/master@{#291876}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -51 lines) Patch
M content/content.gyp View 1 2 8 chunks +11 lines, -6 lines 0 comments Download
D content/content_resources.gyp View 1 chunk +0 lines, -36 lines 0 comments Download
A + content/content_resources.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_shell.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Lei Zhang
Follow up to https://codereview.chromium.org/495423004/
6 years, 4 months ago (2014-08-23 01:23:24 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-08-24 17:21:32 UTC) #2
Lei Zhang
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-25 21:29:54 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-25 21:32:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/498673005/40001
6 years, 3 months ago (2014-08-25 21:34:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-25 22:50:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-25 22:56:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6506)
6 years, 3 months ago (2014-08-25 22:56:10 UTC) #8
Lei Zhang
thestig@chromium.org changed reviewers: + benwells@chromium.org
6 years, 3 months ago (2014-08-26 00:34:16 UTC) #9
Lei Zhang
On 2014/08/26 00:34:16, Lei Zhang wrote: > mailto:thestig@chromium.org changed reviewers: > + mailto:benwells@chromium.org TBR for ...
6 years, 3 months ago (2014-08-26 00:35:03 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-26 07:25:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/498673005/60001
6 years, 3 months ago (2014-08-26 07:27:06 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (60001) as 2078037467c85e2e5f4c4eaf3a09accac7d0291d
6 years, 3 months ago (2014-08-26 10:01:50 UTC) #13
tfarina
Jochen, fyi! (as it was his TODO).
6 years, 3 months ago (2014-08-27 19:20:08 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:46 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bce0267e0d1abfb8a279c00be1497d941020a6a5
Cr-Commit-Position: refs/heads/master@{#291876}

Powered by Google App Engine
This is Rietveld 408576698