content/browser/android/java/gin_java_bridge_dispatcher_host.h - Issue 498633003: Cache pending JS bridge sync IPC replies, and send in case of RenderFrame deletion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bridge_dispatcher_host.h

Issue 498633003: Cache pending JS bridge sync IPC replies, and send in case of RenderFrame deletion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments and a test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java ('k') | content/browser/android/java/gin_java_bridge_dispatcher_host.cc » ('j') | content/browser/android/java/gin_java_bridge_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bridge_dispatcher_host.h

diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.h b/content/browser/android/java/gin_java_bridge_dispatcher_host.h

index 615c2b03770af4197ec1a0799a0cfe3bc4191b65..c6033d1991c960e4a12520d19bb3b9fed1035b0f 100644

--- a/content/browser/android/java/gin_java_bridge_dispatcher_host.h

+++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.h

@@ -114,6 +114,13 @@ class GinJavaBridgeDispatcherHost

typedef std::map<std::string, GinJavaBoundObject::ObjectID> NamedObjectMap;

NamedObjectMap named_objects_;

+ // Keep track of pending calls out to Java such that we can send a synchronous

+ // reply to the renderer waiting on the response should the RenderFrame be

+ // destroyed while the reply is pending.

+ // Only used on the UI thread.

+ typedef std::map<RenderFrameHost*, IPC::Message*> PendingReplyMap;

+ PendingReplyMap pending_replies_;

DISALLOW_COPY_AND_ASSIGN(GinJavaBridgeDispatcherHost);

};