Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: content/browser/android/java/gin_java_bridge_dispatcher_host.h

Issue 498633003: Cache pending JS bridge sync IPC replies, and send in case of RenderFrame deletion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Factor out reply_msg param where possible Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_
6 #define CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_ 6 #define CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 const base::ListValue& arguments, 71 const base::ListValue& arguments,
72 IPC::Message* reply_msg); 72 IPC::Message* reply_msg);
73 73
74 private: 74 private:
75 void OnObjectWrapperDeleted(RenderFrameHost* render_frame_host, 75 void OnObjectWrapperDeleted(RenderFrameHost* render_frame_host,
76 GinJavaBoundObject::ObjectID object_id); 76 GinJavaBoundObject::ObjectID object_id);
77 77
78 bool IsValidRenderFrameHost(RenderFrameHost* render_frame_host); 78 bool IsValidRenderFrameHost(RenderFrameHost* render_frame_host);
79 void SendReply(RenderFrameHost* render_frame_host, IPC::Message* reply_msg); 79 void SendReply(RenderFrameHost* render_frame_host, IPC::Message* reply_msg);
80 void SendMethods(RenderFrameHost* render_frame_host, 80 void SendMethods(RenderFrameHost* render_frame_host,
81 IPC::Message* reply_msg,
82 const std::set<std::string>& method_names); 81 const std::set<std::string>& method_names);
83 void SendHasMethodReply(RenderFrameHost* render_frame_host, 82 void SendHasMethodReply(RenderFrameHost* render_frame_host,
84 IPC::Message* reply_msg,
85 bool result); 83 bool result);
86 void ProcessMethodInvocationResult( 84 void ProcessMethodInvocationResult(
87 RenderFrameHost* render_frame_host, 85 RenderFrameHost* render_frame_host,
88 IPC::Message* reply_msg,
89 scoped_refptr<GinJavaMethodInvocationHelper> result); 86 scoped_refptr<GinJavaMethodInvocationHelper> result);
90 void ProcessMethodInvocationObjectResult( 87 void ProcessMethodInvocationObjectResult(
91 RenderFrameHost* render_frame_host, 88 RenderFrameHost* render_frame_host,
92 IPC::Message* reply_msg,
93 scoped_refptr<GinJavaMethodInvocationHelper> result); 89 scoped_refptr<GinJavaMethodInvocationHelper> result);
94 GinJavaBoundObject::ObjectID AddObject( 90 GinJavaBoundObject::ObjectID AddObject(
95 const base::android::JavaRef<jobject>& object, 91 const base::android::JavaRef<jobject>& object,
96 const base::android::JavaRef<jclass>& safe_annotation_clazz, 92 const base::android::JavaRef<jclass>& safe_annotation_clazz,
97 bool is_named, 93 bool is_named,
98 RenderFrameHost* holder); 94 RenderFrameHost* holder);
99 bool FindObjectId(const base::android::JavaRef<jobject>& object, 95 bool FindObjectId(const base::android::JavaRef<jobject>& object,
100 GinJavaBoundObject::ObjectID* object_id); 96 GinJavaBoundObject::ObjectID* object_id);
101 void RemoveHolder(RenderFrameHost* holder, 97 void RemoveHolder(RenderFrameHost* holder,
102 const GinJavaBoundObject::ObjectMap::iterator& from, 98 const GinJavaBoundObject::ObjectMap::iterator& from,
103 size_t count); 99 size_t count);
100 IPC::Message* GetPendingReply(RenderFrameHost* render_frame_host);
104 101
105 // Every time a GinJavaBoundObject backed by a real Java object is 102 // Every time a GinJavaBoundObject backed by a real Java object is
106 // created/destroyed, we insert/remove a strong ref to that Java object into 103 // created/destroyed, we insert/remove a strong ref to that Java object into
107 // this set so that it doesn't get garbage collected while it's still 104 // this set so that it doesn't get garbage collected while it's still
108 // potentially in use. Although the set is managed native side, it's owned 105 // potentially in use. Although the set is managed native side, it's owned
109 // and defined in Java so that pushing refs into it does not create new GC 106 // and defined in Java so that pushing refs into it does not create new GC
110 // roots that would prevent ContentViewCore from being garbage collected. 107 // roots that would prevent ContentViewCore from being garbage collected.
111 JavaObjectWeakGlobalRef retained_object_set_; 108 JavaObjectWeakGlobalRef retained_object_set_;
112 bool allow_object_contents_inspection_; 109 bool allow_object_contents_inspection_;
113 GinJavaBoundObject::ObjectMap objects_; 110 GinJavaBoundObject::ObjectMap objects_;
114 typedef std::map<std::string, GinJavaBoundObject::ObjectID> NamedObjectMap; 111 typedef std::map<std::string, GinJavaBoundObject::ObjectID> NamedObjectMap;
115 NamedObjectMap named_objects_; 112 NamedObjectMap named_objects_;
116 113
114 // Keep track of pending calls out to Java such that we can send a synchronous
115 // reply to the renderer waiting on the response should the RenderFrame be
116 // destroyed while the reply is pending.
117 // Only used on the UI thread.
118 typedef std::map<RenderFrameHost*, IPC::Message*> PendingReplyMap;
119 PendingReplyMap pending_replies_;
120
117 DISALLOW_COPY_AND_ASSIGN(GinJavaBridgeDispatcherHost); 121 DISALLOW_COPY_AND_ASSIGN(GinJavaBridgeDispatcherHost);
118 }; 122 };
119 123
120 } // namespace content 124 } // namespace content
121 125
122 #endif // CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_ 126 #endif // CONTENT_BROWSER_ANDROID_JAVA_GIN_JAVA_BRIDGE_DISPATCHER_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698