Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: trunk/src/chrome/renderer/resources/extensions/extension_options_events.js

Issue 498633002: Revert 291286: broke 'ExtensionOptionsApiTest.ExtensionCanEmbedOwnOptions'. (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/renderer/resources/extensions/extension_options_events.js
===================================================================
--- trunk/src/chrome/renderer/resources/extensions/extension_options_events.js (revision 291327)
+++ trunk/src/chrome/renderer/resources/extensions/extension_options_events.js (working copy)
@@ -16,10 +16,10 @@
},
'sizechanged': {
evt: CreateEvent('extensionOptionsInternal.onSizeChanged'),
- customHandler: function(handler, event, extensionOptionsEvent) {
- handler.handleSizeChangedEvent(event, extensionOptionsEvent);
+ customHandler: function(handler, event, webViewEvent) {
+ handler.handleSizeChangedEvent(event, webViewEvent);
},
- fields:['newWidth', 'newHeight', 'oldWidth', 'oldHeight']
+ fields:['width', 'height']
}
}
@@ -63,10 +63,8 @@
ExtensionOptionsEvents.prototype.handleSizeChangedEvent = function(
event, extensionOptionsEvent) {
- this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.newWidth,
- extensionOptionsEvent.newHeight,
- extensionOptionsEvent.oldWidth,
- extensionOptionsEvent.oldHeight);
+ this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.width,
+ extensionOptionsEvent.height);
this.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent);
}

Powered by Google App Engine
This is Rietveld 408576698