Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: trunk/src/chrome/renderer/resources/extensions/extension_options_events.js

Issue 498633002: Revert 291286: broke 'ExtensionOptionsApiTest.ExtensionCanEmbedOwnOptions'. (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var EventBindings = require('event_bindings'); 5 var EventBindings = require('event_bindings');
6 6
7 var CreateEvent = function(name) { 7 var CreateEvent = function(name) {
8 var eventOpts = {supportsListeners: true, supportsFilters: true}; 8 var eventOpts = {supportsListeners: true, supportsFilters: true};
9 return new EventBindings.Event(name, undefined, eventOpts); 9 return new EventBindings.Event(name, undefined, eventOpts);
10 }; 10 };
11 11
12 var EXTENSION_OPTIONS_EVENTS = { 12 var EXTENSION_OPTIONS_EVENTS = {
13 'load': { 13 'load': {
14 evt: CreateEvent('extensionOptionsInternal.onLoad'), 14 evt: CreateEvent('extensionOptionsInternal.onLoad'),
15 fields: [] 15 fields: []
16 }, 16 },
17 'sizechanged': { 17 'sizechanged': {
18 evt: CreateEvent('extensionOptionsInternal.onSizeChanged'), 18 evt: CreateEvent('extensionOptionsInternal.onSizeChanged'),
19 customHandler: function(handler, event, extensionOptionsEvent) { 19 customHandler: function(handler, event, webViewEvent) {
20 handler.handleSizeChangedEvent(event, extensionOptionsEvent); 20 handler.handleSizeChangedEvent(event, webViewEvent);
21 }, 21 },
22 fields:['newWidth', 'newHeight', 'oldWidth', 'oldHeight'] 22 fields:['width', 'height']
23 } 23 }
24 } 24 }
25 25
26 /** 26 /**
27 * @constructor 27 * @constructor
28 */ 28 */
29 function ExtensionOptionsEvents(extensionOptionsInternal, viewInstanceId) { 29 function ExtensionOptionsEvents(extensionOptionsInternal, viewInstanceId) {
30 this.extensionOptionsInternal = extensionOptionsInternal; 30 this.extensionOptionsInternal = extensionOptionsInternal;
31 this.viewInstanceId = viewInstanceId; 31 this.viewInstanceId = viewInstanceId;
32 this.setup(); 32 this.setup();
(...skipping 23 matching lines...) Expand all
56 return; 56 return;
57 } 57 }
58 self.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent); 58 self.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent);
59 }, {instanceId: self.viewInstanceId}); 59 }, {instanceId: self.viewInstanceId});
60 60
61 this.extensionOptionsInternal.setupEventProperty(name); 61 this.extensionOptionsInternal.setupEventProperty(name);
62 }; 62 };
63 63
64 ExtensionOptionsEvents.prototype.handleSizeChangedEvent = function( 64 ExtensionOptionsEvents.prototype.handleSizeChangedEvent = function(
65 event, extensionOptionsEvent) { 65 event, extensionOptionsEvent) {
66 this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.newWidth, 66 this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.width,
67 extensionOptionsEvent.newHeight, 67 extensionOptionsEvent.height);
68 extensionOptionsEvent.oldWidth,
69 extensionOptionsEvent.oldHeight);
70 this.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent); 68 this.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent);
71 } 69 }
72 70
73 exports.ExtensionOptionsEvents = ExtensionOptionsEvents; 71 exports.ExtensionOptionsEvents = ExtensionOptionsEvents;
74 exports.CreateEvent = CreateEvent; 72 exports.CreateEvent = CreateEvent;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698