Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 498633002: Revert 291286: broke 'ExtensionOptionsApiTest.ExtensionCanEmbedOwnOptions'. (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 4 months ago
Reviewers:
ericzeng
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 291286: broke 'ExtensionOptionsApiTest.ExtensionCanEmbedOwnOptions'. The test is failing on all platforms with the following error message: "[FAIL] createGuestViewDOM: uncaught exception: Error in event handler for extensionOptionsInternal.onSizeChanged: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params) Stack trace: Error: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params) at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:113:11) at Object.\u003Canonymous> (extensions::binding:326:30) at ExtensionOptionsInternal.resize (extensions::extensionOptions:178:21) at ExtensionOptionsInternal.onSizeChanged (extensions::extensionOptions:153:10) at ExtensionOptionsEvents.handleSizeChangedEvent (extensions::extensionOptionsEvents:66:33) at Object.EXTENSION_OPTIONS_EVENTS.sizechanged.customHandler (extensions::extensionOptionsEvents:20:15) at info.evt.addListener.instanceId (extensions::extensionOptionsEvents:55:12) at EventImpl.dispatchToListener (extensions::event_bindings:397:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) Error at extensions::test:93:22 at exports.handle (extensions::uncaught_exception_handler:15:3) at EventImpl.dispatch_ (extensions::event_bindings:384:9) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://obocclgnomgjhjnenilbpmgkgfmdhecn/test.html (0) > Implement smoother autosizing of the extension options overlay > > - Use element.animate to resize the overlay for embedded extension > options. When an <extensionoptions> element is embedded in a WebUI > overlay, if its size changes the overlay will smoothly expand to > surround the element. > - Add an API to <extensionoptions> to defer autosizing until its > embedder is ready. This is used to 'pin' the element's size until > the overlay is done expanding. > - Move the <extensionoptions> off screen until the overlay is done > expanding. > - Prevent <extensionoptions> from shrinking after the initial sizing. > This makes the look of the embedded options page more consistent. > > BUG=386842 > > Review URL: https://codereview.chromium.org/480243003 TBR=ericzeng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291328

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 4 months ago (2014-08-22 04:07:39 UTC) #1
sadrul
6 years, 4 months ago (2014-08-22 04:08:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r291328 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698