Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Issue 498603002: Port parts of //third_pary/libjingle build to GN (Closed)

Created:
6 years, 4 months ago by awong
Modified:
6 years, 3 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Port parts of //third_pary/libjingle build to GN Reimplements parts of //third_party/libjingle's build in GN. The new build is much less flexible than the original. No configuration variables have been ported. Some windows-specific configs have been left out and annotated with TODOs. Most signifcantly, the entirety of the 'if (enable_webrtc)' block has been omitted, because the GN build for webrtc isn't working yet. Despite these limitations, it is an adequate replacement for the 'stub' libjingle target in most situations. Note, this CL is a near direct copy of rlarocque's work at https://codereview.chromium.org/455583002/ BUG=none TBR=sky,pavely,rlarocque Committed: https://crrev.com/f7b1cb6926cabc20a89b2713e8c59402e6d260af Cr-Commit-Position: refs/heads/master@{#291587}

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : fix gn compile #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -40 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 chunks +1 line, -2 lines 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M components/invalidation/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 3 chunks +6 lines, -19 lines 0 comments Download
A third_party/libjingle/BUILD.gn View 1 chunk +344 lines, -0 lines 1 comment Download
M third_party/libjingle/libjingle.gyp View 6 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
awong
Picking this up from Richard. PTAL.
6 years, 4 months ago (2014-08-22 00:59:35 UTC) #1
brettw
LGTM!
6 years, 4 months ago (2014-08-22 20:13:47 UTC) #2
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 4 months ago (2014-08-22 22:04:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/498603002/40001
6 years, 4 months ago (2014-08-22 22:05:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 23:31:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 23:34:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6195)
6 years, 4 months ago (2014-08-22 23:34:26 UTC) #7
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 4 months ago (2014-08-22 23:46:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/498603002/40001
6 years, 4 months ago (2014-08-22 23:48:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (40001) as 9bdda7c72c9d81d241a49645dd26fb8dabf294a4
6 years, 4 months ago (2014-08-23 21:36:30 UTC) #10
kjellander_chromium
ajwong: I noticed a typo in this CL. Can you fix? https://codereview.chromium.org/498603002/diff/40001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): ...
6 years, 3 months ago (2014-08-30 06:41:25 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:14 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7b1cb6926cabc20a89b2713e8c59402e6d260af
Cr-Commit-Position: refs/heads/master@{#291587}

Powered by Google App Engine
This is Rietveld 408576698