Add relaunch into ASH and desktop support for Chrome on Windows 7.

Add relaunch into ASH and desktop support for Chrome on Windows 7.

This is on similar lines as Windows 8. The difference being launching into ASH on Windows 8 launches
ASH into Windows 8 metro environment.

Reused the existing tunneling we have via delegate_execute to ensure that the calling process is terminated
before launching the browser into the other environment.

Removed the erstshile Open Ash Desktop and Close Ash Desktop menu options as they are no longer needed and they
don't work correctly anyways.

BUG=356475
Committed: https://crrev.com/196db19755cd25d7da5371442c2394e1510051ad
Cr-Commit-Position: refs/heads/master@{#292464}

[ananta, 2014-08-22 21:15:54]

+sky for chrome\app and chrome\browser

[cpu_(ooo_6.6-7.5), 2014-08-22 21:47:12]

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/plugins/p...
File chrome/browser/plugins/plugin_infobar_delegates.cc (right):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/plugins/p...
chrome/browser/plugins/plugin_infobar_delegates.cc:484: InfoBarButton button)
const {
don't you have to use USE_AURA ? or is this not compiled on mac?

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:495:
content::RecordAction(base::UserMetricsAction("Win7DesktopRestart"));
is there an xml file you need to edit to have this shown in a dashboard?

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (left):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_model.cc:570: 
same question about mac in the next line (USE_AURA)

https://codereview.chromium.org/498573003/diff/80001/win8/delegate_execute/de...
File win8/delegate_execute/delegate_execute.cc (right):

https://codereview.chromium.org/498573003/diff/80001/win8/delegate_execute/de...
win8/delegate_execute/delegate_execute.cc:120: 
lets add a comment here about why we launch the win7 and win8 processes
differently.

[ananta, 2014-08-22 22:17:53]

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/plugins/p...
File chrome/browser/plugins/plugin_infobar_delegates.cc (right):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/plugins/p...
chrome/browser/plugins/plugin_infobar_delegates.cc:484: InfoBarButton button)
const {
On 2014/08/22 21:47:11, cpu wrote:
> don't you have to use USE_AURA ? or is this not compiled on mac?

This block is under OS_WIN

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/browse...
chrome/browser/ui/browser_command_controller.cc:495:
content::RecordAction(base::UserMetricsAction("Win7DesktopRestart"));
On 2014/08/22 21:47:11, cpu wrote:
> is there an xml file you need to edit to have this shown in a dashboard?

Will look into that.

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (left):

https://codereview.chromium.org/498573003/diff/80001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/wrench_menu_model.cc:570: 
On 2014/08/22 21:47:11, cpu wrote:
> same question about mac in the next line (USE_AURA)

under OS_WIN. So no issue

https://codereview.chromium.org/498573003/diff/80001/win8/delegate_execute/de...
File win8/delegate_execute/delegate_execute.cc (right):

https://codereview.chromium.org/498573003/diff/80001/win8/delegate_execute/de...
win8/delegate_execute/delegate_execute.cc:120: 
On 2014/08/22 21:47:11, cpu wrote:
> lets add a comment here about why we launch the win7 and win8 processes
> differently.

Done.

[cpu_(ooo_6.6-7.5), 2014-08-26 03:37:06]

lgtm

[cpu_(ooo_6.6-7.5), 2014-08-26 03:37:37]

btw you need a review for the xml file.

[sky, 2014-08-26 16:51:23]

https://codereview.chromium.org/498573003/diff/120001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/498573003/diff/120001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13854: +        Relaunch Chrome in Windows
ASH mode
Do we really want to present the name ASH to the user? I don't believe we've
ever trademarked it or anything.

[ananta, 2014-08-26 18:44:50]

ananta@chromium.org changed reviewers:
+ jar@chromium.org

[ananta, 2014-08-26 18:45:09]

+jar for metrics.xml owners review.

[jar (doing other things), 2014-08-26 18:53:11]

jar@chromium.org changed reviewers:
+ asvitkine@chromium.org
- jar@chromium.org

[jar (doing other things), 2014-08-26 18:53:11]

+asvitkine for histograms.xml review

[Alexei Svitkine (slow), 2014-08-26 20:20:20]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org

[Alexei Svitkine (slow), 2014-08-26 20:20:20]

+jwd for histograms review, as I'm currently OOO.

[ananta, 2014-08-26 22:34:17]

https://codereview.chromium.org/498573003/diff/120001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/498573003/diff/120001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13854: +        Relaunch Chrome in Windows
ASH mode
On 2014/08/26 16:51:22, sky wrote:
> Do we really want to present the name ASH to the user? I don't believe we've
> ever trademarked it or anything.

Changed to Chrome OS mode for now based on a discussion with cpu

[sky, 2014-08-26 22:57:07]

It may be worth renaming the IDRs too, but I leave that to you.

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13869: +               desc="Text for the
menu item to restart chrome in ASH. Aplies to Windows 7 only">
ash->chromeos

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13873: +               desc="Modal message
box prompt shown to the user after requesting to relaunch in Windows ASH mode
while packaged apps are running, which will require all packaged apps to be
closed and then restarted. Dialog is shown with choices: OK, Cancel.">
ash->chrome os

[sky, 2014-08-26 22:57:12]

LGTM

[ananta, 2014-08-27 00:30:11]

On 2014/08/26 22:57:07, sky wrote:
> It may be worth renaming the IDRs too, but I leave that to you.
> 
>
https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:13869: +               desc="Text for the
> menu item to restart chrome in ASH. Aplies to Windows 7 only">
> ash->chromeos
> 
>
https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:13873: +               desc="Modal message
> box prompt shown to the user after requesting to relaunch in Windows ASH mode
> while packaged apps are running, which will require all packaged apps to be
> closed and then restarted. Dialog is shown with choices: OK, Cancel.">
> ash->chrome os

I also changed the IDRs

[ananta, 2014-08-27 00:30:24]

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13869: +               desc="Text for the
menu item to restart chrome in ASH. Aplies to Windows 7 only">
On 2014/08/26 22:57:07, sky wrote:
> ash->chromeos

Done.

https://codereview.chromium.org/498573003/diff/140001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13873: +               desc="Modal message
box prompt shown to the user after requesting to relaunch in Windows ASH mode
while packaged apps are running, which will require all packaged apps to be
closed and then restarted. Dialog is shown with choices: OK, Cancel.">
On 2014/08/26 22:57:07, sky wrote:
> ash->chrome os

Done.

[cpu_(ooo_6.6-7.5), 2014-08-27 09:10:21]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-08-27 09:10:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/160001

[commit-bot: I haz the power, 2014-08-27 09:14:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-27 09:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 09:15:51]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[jwd, 2014-08-27 15:43:24]

jwd@chromium.org changed reviewers:
+ isherman@chromium.org

[jwd, 2014-08-27 15:43:24]

LGTM for metrics changes.
+isherman for actual metrics owners review

[ananta, 2014-08-27 21:42:57]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-27 21:44:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/160001

[commit-bot: I haz the power, 2014-08-27 21:49:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-27 21:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 21:51:28]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Ilya Sherman, 2014-08-27 21:56:50]

actions.xml LGTM % nits.

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:11353: <description>Tracks when Chrome was
restarted in metro on Win8.</description>
nit: It's a little odd that this has the order "in foo on Win8" whereas the
action above has the order "on Win8 in foo".

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:11369: <description>Tracks when Chrome was
restarted in ASH on Win7.</description>
nit: "ASH" -> "Ash" (right?)

[ananta, 2014-08-27 22:06:40]

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:11353: <description>Tracks when Chrome was
restarted in metro on Win8.</description>
On 2014/08/27 21:56:50, Ilya Sherman wrote:
> nit: It's a little odd that this has the order "in foo on Win8" whereas the
> action above has the order "on Win8 in foo".

Done.

https://codereview.chromium.org/498573003/diff/160001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:11369: <description>Tracks when Chrome was
restarted in ASH on Win7.</description>
On 2014/08/27 21:56:50, Ilya Sherman wrote:
> nit: "ASH" -> "Ash" (right?)

Done.

[ananta, 2014-08-27 22:06:44]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:09:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/180001

[ananta, 2014-08-27 22:17:55]

The CQ bit was unchecked by ananta@chromium.org

[ananta, 2014-08-27 23:04:37]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:05:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/220001

[commit-bot: I haz the power, 2014-08-28 05:07:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-28 05:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:30:52]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[ananta, 2014-08-28 05:51:17]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:52:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/220001

[commit-bot: I haz the power, 2014-08-28 11:07:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-28 11:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 11:32:21]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[ananta, 2014-08-28 18:38:05]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-28 18:38:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/260001

[commit-bot: I haz the power, 2014-08-28 19:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 19:48:59]

Failed to commit the patch.

[ananta, 2014-08-28 19:49:36]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-28 19:51:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/260001

[commit-bot: I haz the power, 2014-08-28 19:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 19:53:15]

Failed to commit the patch.

[ananta, 2014-08-28 21:20:41]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:21:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/498573003/260001

[commit-bot: I haz the power, 2014-08-28 21:38:18]

Committed patchset #14 (id:260001) as d0ae379ed68037729660aa10c7651c17f95fda6a

[commit-bot: I haz the power, 2014-09-10 03:02:19]

Patchset 14 (id:??) landed as
https://crrev.com/196db19755cd25d7da5371442c2394e1510051ad
Cr-Commit-Position: refs/heads/master@{#292464}