Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 498573002: GN: Declare dep from media/base/android to widevine_cdm_version copy step (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
qinmin, scottmg
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Declare dep from media/base/android to widevine_cdm_version copy step media/base/android/media_drm_bridge.cc #includes widevine_cdm_version.h assuming it's in the out dir, so it must declare a dependency on //third_party/widevine/cdm:version_h which actually puts the file there. TBR=qinmin@chromium.org (build fix)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/base/android/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jamesr
6 years, 4 months ago (2014-08-21 23:56:42 UTC) #1
jamesr
This should fix a flaky failing compile on the android GN bot.
6 years, 4 months ago (2014-08-21 23:56:56 UTC) #2
scottmg
lgtm
6 years, 4 months ago (2014-08-21 23:57:12 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-22 00:00:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/498573002/1
6 years, 4 months ago (2014-08-22 00:02:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:51:50 UTC) #6
jamesr
[5719/7465 | 118.799] ACTION //sync/protocol:protocol_gen(//build/toolchain/android:arm) FAILED: python ../../tools/protoc_wrapper/protoc_wrapper.py --protobuf gen/components/enhanced_bookmarks/proto/metadata.pb.h --proto-in-dir ../../components/enhanced_bookmarks/proto --proto-in-file metadata.proto --use-system-protobuf=0 ...
6 years, 4 months ago (2014-08-22 00:53:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 01:00:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8291)
6 years, 4 months ago (2014-08-22 01:00:50 UTC) #9
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-22 05:31:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/498573002/1
6 years, 4 months ago (2014-08-22 05:31:43 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:37:17 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:42:45 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 05:42:46 UTC) #14
Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

Powered by Google App Engine
This is Rietveld 408576698