tools/perf/metrics/speedindex.py - Issue 498563002: Delete now unused PageMeasurement class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/speedindex.py

Issue 498563002: Delete now unused PageMeasurement class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/speedindex.py

diff --git a/tools/perf/metrics/speedindex.py b/tools/perf/metrics/speedindex.py

index 296c81934c48749b21ef69e2907998eca87bc336..bfd415842b103586fca0acef8ccddb5ba202d0d8 100644

--- a/tools/perf/metrics/speedindex.py

+++ b/tools/perf/metrics/speedindex.py

@@ -32,7 +32,7 @@ class SpeedIndexMetric(Metric):

"""Start recording events.

This method should be called in the WillNavigateToPage method of

- a PageMeasurement, so that all the events can be captured. If it's called

+ a PageTest, so that all the events can be captured. If it's called

in DidNavigateToPage, that will be too late.

"""

self._impl = (VideoSpeedIndexImpl() if tab.video_capture_supported else

« no previous file with comments | « tools/perf/metrics/memory.py ('k') | tools/telemetry/telemetry/page/page_measurement.py » ('j') | no next file with comments »