Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: tools/perf/metrics/__init__.py

Issue 498563002: Delete now unused PageMeasurement class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/metrics/memory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/__init__.py
diff --git a/tools/perf/metrics/__init__.py b/tools/perf/metrics/__init__.py
index 67c4def44cdfc0976a0a7c43e7f3a1cf7abd231a..69ca3a15fc43b202e5fbf203d9adf7be5b652cc1 100644
--- a/tools/perf/metrics/__init__.py
+++ b/tools/perf/metrics/__init__.py
@@ -6,7 +6,7 @@ class Metric(object):
"""Base class for all the metrics that are used by telemetry measurements.
The Metric class represents a way of measuring something. Metrics are
- helper classes used by PageMeasurements. Each PageMeasurement may use
+ helper classes used by PageTests. Each PageTest may use
multiple metrics; each metric should be focussed on collecting data
about one thing.
"""
@@ -35,7 +35,7 @@ class Metric(object):
"""Add the data collected into the results object for a measurement.
Metrics may implement AddResults to provide a common way to add results
- to the PageTestResults in PageMeasurement.AddMeasurement --
+ to the PageTestResults in PageTest.ValidateOrMeasurePage --
results should be added with results.AddValue(...).
"""
raise NotImplementedError()
« no previous file with comments | « no previous file | tools/perf/metrics/memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698