Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: content/browser/loader/temporary_file_stream.cc

Issue 498553004: Remove implicit conversions from scoped_refptr to T* in content/browser/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/temporary_file_stream.h" 5 #include "content/browser/loader/temporary_file_stream.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/files/file_proxy.h" 9 #include "base/files/file_proxy.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 25 matching lines...) Expand all
36 // Cancelled or not, create the deletable_file so the temporary is cleaned up. 36 // Cancelled or not, create the deletable_file so the temporary is cleaned up.
37 scoped_refptr<ShareableFileReference> deletable_file = 37 scoped_refptr<ShareableFileReference> deletable_file =
38 ShareableFileReference::GetOrCreate( 38 ShareableFileReference::GetOrCreate(
39 file_path, 39 file_path,
40 ShareableFileReference::DELETE_ON_FINAL_RELEASE, 40 ShareableFileReference::DELETE_ON_FINAL_RELEASE,
41 task_runner.get()); 41 task_runner.get());
42 42
43 scoped_ptr<net::FileStream> file_stream( 43 scoped_ptr<net::FileStream> file_stream(
44 new net::FileStream(file_proxy->TakeFile(), task_runner)); 44 new net::FileStream(file_proxy->TakeFile(), task_runner));
45 45
46 callback.Run(error_code, file_stream.Pass(), deletable_file); 46 callback.Run(error_code, file_stream.Pass(), deletable_file.get());
47 } 47 }
48 48
49 } // namespace 49 } // namespace
50 50
51 void CreateTemporaryFileStream( 51 void CreateTemporaryFileStream(
52 const CreateTemporaryFileStreamCallback& callback) { 52 const CreateTemporaryFileStreamCallback& callback) {
53 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 53 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
54 54
55 scoped_ptr<base::FileProxy> file_proxy(new base::FileProxy( 55 scoped_ptr<base::FileProxy> file_proxy(new base::FileProxy(
56 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get())); 56 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get()));
57 base::FileProxy* proxy = file_proxy.get(); 57 base::FileProxy* proxy = file_proxy.get();
58 proxy->CreateTemporary( 58 proxy->CreateTemporary(
59 base::File::FLAG_ASYNC, 59 base::File::FLAG_ASYNC,
60 base::Bind(&DidCreateTemporaryFile, callback, Passed(&file_proxy))); 60 base::Bind(&DidCreateTemporaryFile, callback, Passed(&file_proxy)));
61 } 61 }
62 62
63 } // namespace content 63 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/loader/upload_data_stream_builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698