Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: runtime/vm/parser.cc

Issue 49853004: Implement stricter rule about self referencing typedefs (fix issue 13675). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.h ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 29456)
+++ runtime/vm/parser.cc (working copy)
@@ -3995,7 +3995,7 @@
bool is_alias_name = false;
if (IsIdentifier() && (LookaheadToken(1) == Token::kLT)) {
ConsumeToken();
- if (TryParseTypeParameter() && (CurrentToken() == Token::kLPAREN)) {
+ if (TryParseTypeParameters() && (CurrentToken() == Token::kLPAREN)) {
is_alias_name = true;
}
}
@@ -4014,7 +4014,7 @@
bool is_mixin_def = false;
if (IsIdentifier() && (LookaheadToken(1) == Token::kLT)) {
ConsumeToken();
- if (TryParseTypeParameter() && (CurrentToken() == Token::kASSIGN)) {
+ if (TryParseTypeParameters() && (CurrentToken() == Token::kASSIGN)) {
is_mixin_def = true;
}
}
@@ -5587,7 +5587,7 @@
// Returns true if the current and next tokens can be parsed as type
// parameters. Current token position is not saved and restored.
-bool Parser::TryParseTypeParameter() {
+bool Parser::TryParseTypeParameters() {
if (CurrentToken() == Token::kLT) {
// We are possibly looking at type parameters. Find closing ">".
int nesting_level = 0;
@@ -5672,7 +5672,7 @@
if (CurrentToken() == Token::kIDENT) {
QualIdent type_name;
ParseQualIdent(&type_name);
- if ((CurrentToken() == Token::kLT) && !TryParseTypeParameter()) {
+ if ((CurrentToken() == Token::kLT) && !TryParseTypeParameters()) {
return false;
}
}
« no previous file with comments | « runtime/vm/parser.h ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698