Tools/GardeningServer/ui/test/ct-failure-card-tests.html - Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/ui/test/ct-failure-card-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: sort git hashes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Tools/GardeningServer/ui/ct-failure-analyzer.html ('K') | « Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html ('k') | Tools/GardeningServer/ui/test/ct-failure-stream-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/GardeningServer/ui/test/ct-failure-card-tests.html

diff --git a/Tools/GardeningServer/ui/test/ct-failure-card-tests.html b/Tools/GardeningServer/ui/test/ct-failure-card-tests.html

index 3cf951338390510b5806f5fecd24457945ffa248..f9f78bf057f928dcb8da6a90058ccf942ce071f7 100644

--- a/Tools/GardeningServer/ui/test/ct-failure-card-tests.html

+++ b/Tools/GardeningServer/ui/test/ct-failure-card-tests.html

@@ -21,8 +21,7 @@ describe('ct-failure-card', function() {

beforeEach(function(done) {

card = document.createElement('ct-failure-card');

group = new CTFailureGroup('key', [

- new CTFailure('autobot', 'unknown', {}, {'blink':158547},

- {'blink':158544})]);

+ new CTFailure('autobot', 'unknown', {})], ['blink:158544', 'blink:158545']);

card.group = group;

card.commitLog = new CTCommitLogMock();

setTimeout(done);

@@ -37,8 +36,8 @@ describe('ct-failure-card', function() {

setTimeout(function() {

var list = card.shadowRoot.querySelector('ct-commit-list');

var commits = list.shadowRoot.querySelectorAll('ct-commit');

- assert(commits[0].data);

- assert(commits[0].data.summary);

+ assert(commits[1].data);

+ assert(commits[1].data.summary);

done();

});