Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: Tools/GardeningServer/model/test/ct-failure-group-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: sort git hashes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/test/ct-failure-group-tests.html
diff --git a/Tools/GardeningServer/model/test/ct-failure-group-tests.html b/Tools/GardeningServer/model/test/ct-failure-group-tests.html
index 819af171e0621d5c68e83456a78a600eb9513fcc..ccb332580e861121fdc4ec8397756ffad9fc8272 100644
--- a/Tools/GardeningServer/model/test/ct-failure-group-tests.html
+++ b/Tools/GardeningServer/model/test/ct-failure-group-tests.html
@@ -19,19 +19,19 @@ describe('ct-failure-group', function() {
describe('category', function() {
it('should be "default" by default', function() {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
assert.equal(group.category, 'default');
});
it('should be "snoozed" when snoozed', function() {
- var group = new CTFailureGroup('key', [], {snoozeTime: Date.now() + 1000 * 1000});
+ var group = new CTFailureGroup('key', [], [], {snoozeTime: Date.now() + 1000 * 1000});
assert.equal(group.category, 'snoozed');
});
});
describe('snooze', function() {
it('should set isSnoozed', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.snoozeUntil(Date.now() + 1000 * 1000).then(function() {
assert.isTrue(group.isSnoozed);
done();
@@ -41,7 +41,7 @@ describe('ct-failure-group', function() {
describe('unsnooze', function() {
it('should clear isSnoozed', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.snoozeUntil(Date.now() + 1000 * 1000).then(function() {
group.unsnooze().then(function() {
assert.isFalse(group.isSnoozed);
@@ -53,7 +53,7 @@ describe('ct-failure-group', function() {
describe('setBug', function() {
it('should store the bug', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.setBug('123').then(function() {
assert.equal(group.bug, 'http://crbug.com/123');
assert.equal(group._annotation.bug, 'http://crbug.com/123');
@@ -63,7 +63,7 @@ describe('ct-failure-group', function() {
});
it('should support URLs', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.setBug('http://foobar.com/?id=876&x=y').then(function() {
assert.equal(group.bug, 'http://foobar.com/?id=876&x=y');
assert.equal(group._annotation.bug, 'http://foobar.com/?id=876&x=y');
@@ -75,7 +75,7 @@ describe('ct-failure-group', function() {
describe('clearBug', function() {
it('should work', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.setBug('123').then(function() {
group.clearBug().then(function() {
assert.isUndefined(group.bug);
@@ -89,7 +89,7 @@ describe('ct-failure-group', function() {
describe('annotations', function() {
it('should have sensible defaults', function() {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
assert.deepEqual(group._annotation, {});
assert.isFalse(group.isSnoozed);
assert.isUndefined(group.bug);
@@ -97,13 +97,13 @@ describe('ct-failure-group', function() {
});
it('should compute properties', function() {
- var group = new CTFailureGroup('key', [], {snoozeTime: Date.now() + 1000 * 1000, bug: 'http://crbug.com/123'});
+ var group = new CTFailureGroup('key', [], [], {snoozeTime: Date.now() + 1000 * 1000, bug: 'http://crbug.com/123'});
assert.isTrue(group.isSnoozed);
assert.equal(group.bug, 'http://crbug.com/123');
});
it('should be persisted', function(done) {
- var group = new CTFailureGroup('key', []);
+ var group = new CTFailureGroup('key', [], []);
group.snoozeUntil(123).then(function() {
group.setBug('456').then(function() {
CTFailureGroup.fetchAnnotations().then(function(annotations) {

Powered by Google App Engine
This is Rietveld 408576698