Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index d2c82dd98852c53ae2c7a54c57c8630007b86d28..84dca8b99bc095496a5a6785ab3384426da56358 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -68,7 +68,7 @@ found in the LICENSE file.
<ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
<div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
- <ct-commit-list commitList="{{ _commitList }}"></ct-commit-list>
+ <ct-commit-list commitList="{{ group.commitList }}"></ct-commit-list>
</div>
<div id="buttons">
<paper-button id="examine" on-tap="{{ examine }}" label="Examine"></paper-button>
@@ -98,7 +98,6 @@ found in the LICENSE file.
group: null,
commitLog: null,
tree: '',
- _commitList: null,
observe: {
group: '_updateCommitList',
@@ -118,8 +117,8 @@ found in the LICENSE file.
},
_updateCommitList: function() {
- this._commitList = this.group ?
- this.group.commitList(this.commitLog) : undefined;
+ if (this.group && this.commitLog)
+ this.group.commitList.update(this.commitLog);
},
linkBug: function() {
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-analyzer.html ('k') | Tools/GardeningServer/ui/ct-unexpected-failures.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698