Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: Tools/GardeningServer/model/test/ct-failure-group-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/test/ct-failure-group-tests.html
diff --git a/Tools/GardeningServer/model/test/ct-failure-group-tests.html b/Tools/GardeningServer/model/test/ct-failure-group-tests.html
index 7860ca5ce0393eada4d95c1aa0aa965a0ef0f2ab..f94c7eb41f117022db8aaa3186431364bb864f4e 100644
--- a/Tools/GardeningServer/model/test/ct-failure-group-tests.html
+++ b/Tools/GardeningServer/model/test/ct-failure-group-tests.html
@@ -26,19 +26,19 @@ describe('ct-failure-group', function() {
describe('category', function() {
it('should be "default" by default', function() {
- var group = new CTFailureGroup([]);
+ var group = new CTFailureGroup([], undefined);
assert.equal(group.category, 'default');
});
it('should be "snoozed" when snoozed', function() {
- var group = new CTFailureGroup([newFailureWithAnnotation({snoozeTime: Date.now() + 1000 * 1000})]);
+ var group = new CTFailureGroup([newFailureWithAnnotation({snoozeTime: Date.now() + 1000 * 1000})], undefined);
assert.equal(group.category, 'snoozed');
});
});
describe('snooze', function() {
it('should set isSnoozed', function(done) {
- var group = new CTFailureGroup([newFailureWithAnnotation()]);
+ var group = new CTFailureGroup([newFailureWithAnnotation()], undefined);
group.snoozeUntil(Date.now() + 1000 * 1000).then(function() {
assert.isTrue(group.isSnoozed);
done();
@@ -48,7 +48,7 @@ describe('ct-failure-group', function() {
describe('unsnooze', function() {
it('should clear isSnoozed', function(done) {
- var group = new CTFailureGroup([newFailureWithAnnotation()]);
+ var group = new CTFailureGroup([newFailureWithAnnotation()], undefined);
group.snoozeUntil(Date.now() + 1000 * 1000).then(function() {
group.unsnooze().then(function() {
assert.isFalse(group.isSnoozed);
@@ -60,7 +60,7 @@ describe('ct-failure-group', function() {
describe('setBug', function() {
it('should store the bug', function(done) {
- var group = new CTFailureGroup([newFailureWithAnnotation()]);
+ var group = new CTFailureGroup([newFailureWithAnnotation()], undefined);
group.setBug('123').then(function() {
assert.equal(group.bug, 'http://crbug.com/123');
assert.equal(group._annotation.bug, 'http://crbug.com/123');
@@ -70,7 +70,7 @@ describe('ct-failure-group', function() {
});
it('should support URLs', function(done) {
- var group = new CTFailureGroup([newFailureWithAnnotation()]);
+ var group = new CTFailureGroup([newFailureWithAnnotation()], undefined);
group.setBug('http://foobar.com/?id=876&x=y').then(function() {
assert.equal(group.bug, 'http://foobar.com/?id=876&x=y');
assert.equal(group._annotation.bug, 'http://foobar.com/?id=876&x=y');
@@ -82,7 +82,7 @@ describe('ct-failure-group', function() {
describe('clearBug', function() {
it('should work', function(done) {
- var group = new CTFailureGroup([]);
+ var group = new CTFailureGroup([], undefined);
group.setBug('123').then(function() {
group.clearBug().then(function() {
assert.isUndefined(group.bug);
@@ -96,7 +96,7 @@ describe('ct-failure-group', function() {
describe('annotations', function() {
it('should have sensible defaults', function() {
- var group = new CTFailureGroup([]);
+ var group = new CTFailureGroup([], undefined);
assert.deepEqual(group._annotation, {});
assert.isFalse(group.isSnoozed);
assert.isUndefined(group.bug);
@@ -105,7 +105,7 @@ describe('ct-failure-group', function() {
it('should compute properties', function() {
var group = new CTFailureGroup([newFailureWithAnnotation(
- {snoozeTime: Date.now() + 1000 * 1000, bug: 'http://crbug.com/123'})]);
+ {snoozeTime: Date.now() + 1000 * 1000, bug: 'http://crbug.com/123'})], undefined);
assert.isTrue(group.isSnoozed);
assert.equal(group.bug, 'http://crbug.com/123');
});
@@ -115,7 +115,7 @@ describe('ct-failure-group', function() {
new CTFailure('step', 'reason', [
{key: 'a', annotation: {snoozeTime: Date.now() + 1000 * 1000}},
{key: 'b',},
- ])
+ ], undefined)
]);
var notSnoozedMultipleFailures = new CTFailureGroup([
new CTFailure('step', 'reason', [
@@ -124,13 +124,13 @@ describe('ct-failure-group', function() {
new CTFailure('step', 'reason', [
{key: 'b'},
]),
- ]);
+ ], undefined);
var snoozedMultipleAlerts = new CTFailureGroup([
new CTFailure('step', 'reason', [
{key: 'a', annotation: {snoozeTime: Date.now() + 1000 * 1000}},
{key: 'b', annotation: {snoozeTime: Date.now() + 1000 * 1000}},
])
- ]);
+ ], undefined);
var snoozedMultipleFailures = new CTFailureGroup([
new CTFailure('step', 'reason', [
{key: 'a', annotation: {snoozeTime: Date.now() + 1000 * 1000}},
@@ -138,7 +138,7 @@ describe('ct-failure-group', function() {
new CTFailure('step', 'reason', [
{key: 'b', annotation: {snoozeTime: Date.now() + 1000 * 1000}},
]),
- ]);
+ ], undefined);
assert.isFalse(notSnoozedMultipleAlerts.isSnoozed);
assert.isFalse(notSnoozedMultipleFailures.isSnoozed);
assert.isTrue(snoozedMultipleAlerts.isSnoozed);
@@ -154,13 +154,13 @@ describe('ct-failure-group', function() {
{key: 'a', annotation: {snoozeTime: timeFuture}},
{key: 'b', annotation: {snoozeTime: timePast}},
])
- ]);
+ ], undefined);
assert.isFalse(notSnoozed.isSnoozed);
});
it('should be persisted', function(done) {
- var group = new CTFailureGroup([newFailureWithAnnotation(), newFailureWithAnnotation()]);
+ var group = new CTFailureGroup([newFailureWithAnnotation(), newFailureWithAnnotation()], undefined);
group.snoozeUntil(123).then(function() {
group.setBug('456').then(function() {
CTFailureGroup.fetchAnnotations().then(function(annotations) {
« no previous file with comments | « Tools/GardeningServer/model/test/ct-commit-log-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-analyzer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698