Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2652)

Unified Diff: Tools/GardeningServer/model/test/ct-commit-list-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/test/ct-commit-list-tests.html
diff --git a/Tools/GardeningServer/model/test/ct-commit-list-tests.html b/Tools/GardeningServer/model/test/ct-commit-list-tests.html
index 7bd3af97ff4bcfbe71da3c4dc2bc04a8179a8b5b..40d8207f90af1e5698ca5deb282f3e016a9866eb 100644
--- a/Tools/GardeningServer/model/test/ct-commit-list-tests.html
+++ b/Tools/GardeningServer/model/test/ct-commit-list-tests.html
@@ -14,56 +14,14 @@ var assert = chai.assert;
describe('ct-commit-list', function() {
describe('commit list Model', function() {
it('returns commits', function() {
- var group = {
- failures: [
- {
- firstFailingRevisions: {
- 'blink': 158545
- },
- lastPassingRevisions: {
- 'blink': 158544
- }
- }
- ]
- };
-
- var cl = new CTCommitList(group, new CTCommitLogMock());
- assert.lengthOf(cl._commits('blink'), 1);
- });
-
- it('handles a backwards revision range', function() {
- var group = {
- failures: [
- {
- firstFailingRevisions: {
- 'blink': 158544
- },
- lastPassingRevisions: {
- 'blink': 158545
- }
- }
- ]
- };
-
- var cl = new CTCommitList(group, new CTCommitLogMock());
- assert.lengthOf(cl._commits('blink'), 0);
+ var revisions = ['blink:158545'];
+ var cl = new CTCommitList(new CTCommitLogMock(), revisions);
+ assert.lengthOf(cl.repositories, 1);
});
it ('returns repositories', function() {
- var group = {
- failures: [
- {
- firstFailingRevisions: {
- 'blink': 158545
- },
- lastPassingRevisions: {
- 'blink': 158544
- }
- }
- ]
- };
-
- var cl = new CTCommitList(group, new CTCommitLogMock());
+ var revisions = ['blink:158545'];
+ var cl = new CTCommitList(new CTCommitLogMock(), revisions);
var repos = cl.repositories;
assert.lengthOf(repos, 1);
assert.equal(repos[0].name, 'blink');
« no previous file with comments | « Tools/GardeningServer/model/ct-failure-group.html ('k') | Tools/GardeningServer/model/test/ct-commit-log-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698