Tools/GardeningServer/model/ct-failure-group.html - Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/model/ct-failure-group.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/GardeningServer/model/ct-failure.html ('k') | Tools/GardeningServer/model/test/ct-commit-list-tests.html » ('j') | Tools/GardeningServer/ui/ct-failure-analyzer.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/GardeningServer/model/ct-failure-group.html

diff --git a/Tools/GardeningServer/model/ct-failure-group.html b/Tools/GardeningServer/model/ct-failure-group.html

index 7eae058130ed966242df0dd826d4a09f2d8e1489..bf451b6cd726865d8e32692b56b7f86908df83f0 100644

--- a/Tools/GardeningServer/model/ct-failure-group.html

+++ b/Tools/GardeningServer/model/ct-failure-group.html

@@ -7,9 +7,10 @@ found in the LICENSE file.

-function CTFailureGroup(key, failures, annotation) {

+function CTFailureGroup(key, failures, revisions, annotation) {

this.key = key;

this.failures = failures;

+ this.revisions = revisions.slice();

this._annotation = annotation || {};

this._computeProperties();

}

@@ -27,7 +28,7 @@ CTFailureGroup.prototype.unsnooze = function() {

};

CTFailureGroup.prototype.commitList = function(commits) {

- return new CTCommitList(this, commits);

+ return new CTCommitList(commits, this.revisions);

};

CTFailureGroup.prototype.setBug = function(bug) {