Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: Tools/GardeningServer/model/test/ct-commit-log-tests.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <link rel="import" href="../ct-commit-log.html"> 7 <link rel="import" href="../ct-commit-log.html">
8 8
9 <link rel="import" href="../ct-commit-mock.html"> 9 <link rel="import" href="../ct-commit-mock.html">
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 var log = new CTCommitLog(); 46 var log = new CTCommitLog();
47 log._handleResponse(repositoryUrl, repository, exampleCommitData); 47 log._handleResponse(repositoryUrl, repository, exampleCommitData);
48 48
49 var expectedCommits = {}; 49 var expectedCommits = {};
50 log._repositories.names.forEach(function(name) { 50 log._repositories.names.forEach(function(name) {
51 expectedCommits[name] = {}; 51 expectedCommits[name] = {};
52 }); 52 });
53 expectedCommits[repository][commit.revision] = commit; 53 expectedCommits[repository][commit.revision] = commit;
54 assert.deepEqual(log.commits, expectedCommits); 54 assert.deepEqual(log.commits, expectedCommits);
55 55
56 assert.deepEqual(log.range(repository, commit.revision, commit.revision), [c ommit]); 56 var revisions = [commit.revision];
57 assert.deepEqual(log.range(repository, revisions), [commit]);
57 58
58 // This url is different than the one obove because CTCommitLog gets the url 59 // This url is different than the one above because CTCommitLog gets the url
59 // from CTRepositories. 60 // from CTRepositories.
60 var incompleteRepositoryUrl = log._repositories.repositories[repository].rep ositoryUrl; 61 var incompleteRepositoryUrl = log._repositories.repositories[repository].rep ositoryUrl;
61 var incompleteCommitAfter = CTCommit.createIncomplete(incompleteRepositoryUr l, commit.revision + 1, repository); 62
63 var nextRev = String(commit.revision + 1);
64 var incompleteCommitAfter =
65 CTCommit.createIncomplete(incompleteRepositoryUrl, nextRev, repository);
66 revisions.push(nextRev);
62 // Expect an incomplete commit for revision + 1. 67 // Expect an incomplete commit for revision + 1.
63 assert.deepEqual(log.range(repository, commit.revision, commit.revision + 1) , [commit, incompleteCommitAfter]); 68 assert.deepEqual(log.range(repository, revisions), [commit, incompleteCommit After]);
64 69
65 // Expect two incomplete commits: one before and one after. 70 // Expect two incomplete commits: one before and one after.
66 var incompleteCommitBefore = CTCommit.createIncomplete(incompleteRepositoryU rl, commit.revision - 1, repository); 71 var prevRev = String(commit.revision - 1);
67 assert.deepEqual(log.range(repository, commit.revision - 1, commit.revision + 1), 72 var incompleteCommitBefore =
73 CTCommit.createIncomplete(incompleteRepositoryUrl, prevRev, repository);
74 // Inserting at the beginning of the list.
75 revisions.splice(0, 0, prevRev);
76 assert.deepEqual(log.range(repository, revisions),
68 [incompleteCommitBefore, commit, incompleteCommitAfter]); 77 [incompleteCommitBefore, commit, incompleteCommitAfter]);
69 }); 78 });
70 }); 79 });
71 80
72 })(); 81 })();
73 </script> 82 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698